You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/17 02:24:07 UTC
[GitHub] [flink] yjshen opened a new pull request #10875:
[FLINK-15089][connectors]Pulsar sink
yjshen opened a new pull request #10875: [FLINK-15089][connectors]Pulsar sink
URL: https://github.com/apache/flink/pull/10875
## What is the purpose of the change
This PR implements Pulsar sink which is part of FLIP-72, and based on #10455 .
## Brief change log
- `FlinkPulsarSinkBase` for the common structure of a sink which supports at-least-once sink.
- `FlinkPulsarRowSink` for row sink and `FlinkPulsarSink` for POJO sink.
- `CachedPulsarClient` to enable share PulsarClient among tasks in the same JVM. PulsarClient holds all the resources that talks to Pulsar and could be shared by multiple producers.
## Verifying this change
This change is already covered by existing tests, `FlinkPulsarSinkTest`
## Does this pull request potentially affect one of the following parts:
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes )
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10875:
[FLINK-15089][connectors]Pulsar sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10875: [FLINK-15089][connectors]Pulsar sink
URL: https://github.com/apache/flink/pull/10875#issuecomment-575441751
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "781af18f6dccfef18beb2411ef0838f22ee5f1e5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4413",
"triggerID" : "781af18f6dccfef18beb2411ef0838f22ee5f1e5",
"triggerType" : "PUSH"
}, {
"hash" : "781af18f6dccfef18beb2411ef0838f22ee5f1e5",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/144850096",
"triggerID" : "781af18f6dccfef18beb2411ef0838f22ee5f1e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 781af18f6dccfef18beb2411ef0838f22ee5f1e5 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144850096) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4413)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10875:
[FLINK-15089][connectors]Pulsar sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10875: [FLINK-15089][connectors]Pulsar sink
URL: https://github.com/apache/flink/pull/10875#issuecomment-575441751
<!--
Meta data
Hash:781af18f6dccfef18beb2411ef0838f22ee5f1e5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4413 TriggerType:PUSH TriggerID:781af18f6dccfef18beb2411ef0838f22ee5f1e5
Hash:781af18f6dccfef18beb2411ef0838f22ee5f1e5 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144850096 TriggerType:PUSH TriggerID:781af18f6dccfef18beb2411ef0838f22ee5f1e5
-->
## CI report:
* 781af18f6dccfef18beb2411ef0838f22ee5f1e5 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144850096) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4413)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10875:
[FLINK-15089][connectors]Pulsar sink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10875: [FLINK-15089][connectors]Pulsar sink
URL: https://github.com/apache/flink/pull/10875#issuecomment-575441751
<!--
Meta data
Hash:781af18f6dccfef18beb2411ef0838f22ee5f1e5 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:781af18f6dccfef18beb2411ef0838f22ee5f1e5
-->
## CI report:
* 781af18f6dccfef18beb2411ef0838f22ee5f1e5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10875:
[FLINK-15089][connectors]Pulsar sink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10875: [FLINK-15089][connectors]Pulsar sink
URL: https://github.com/apache/flink/pull/10875#issuecomment-575436352
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 781af18f6dccfef18beb2411ef0838f22ee5f1e5 (Fri Jan 17 02:27:39 UTC 2020)
**Warnings:**
* **2 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15089).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services