You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/16 22:33:19 UTC
[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on issue #825:
HDDS-3395. Move the protobuf convert code to the OMHelper
bharatviswa504 edited a comment on issue #825: HDDS-3395. Move the protobuf convert code to the OMHelper
URL: https://github.com/apache/hadoop-ozone/pull/825#issuecomment-614930795
I believe instead of moving proto conversions into OMPBHelper, I believe the current approach of each Class having the logic of conversion to/from protobuf looks cleaner. With the PR approach, there will be one big huge class that does all this conversion. I feel the current way looks easy, wherein a single place has an entire code for it.
Thoughts?? If there is any strong reason in doing this way, I am happy to hear the reasons.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org