You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/08 08:10:26 UTC

[GitHub] [spark] AngersZhuuuu opened a new pull request #33935: [SPARK-36692][CORE] Improve Error statement when requesting thread dump while executor already stopped

AngersZhuuuu opened a new pull request #33935:
URL: https://github.com/apache/spark/pull/33935


   ### What changes were proposed in this pull request?
   For now, when user check thread dump for a executor while this executor is stopped, the error log shows following might disturb users.
   
   ![image](https://user-images.githubusercontent.com/46485123/132471501-db96894d-abe9-4d62-9943-06c578382ef2.png)
   
   
   
   ### Why are the changes needed?
   Improve error message
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33935: [SPARK-36692][CORE] Improve Error statement when requesting thread dump while executor already stopped

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33935:
URL: https://github.com/apache/spark/pull/33935#issuecomment-915146472


   **[Test build #143078 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143078/testReport)** for PR 33935 at commit [`d4b0bd6`](https://github.com/apache/spark/commit/d4b0bd68c08430978654a766fdb10e1930bdc5d8).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33935: [SPARK-36692][CORE] Improve Error statement when requesting thread dump while executor already stopped

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33935:
URL: https://github.com/apache/spark/pull/33935#issuecomment-915095643


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47580/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33935: [SPARK-36692][CORE] Improve Error statement when requesting thread dump while executor already stopped

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33935:
URL: https://github.com/apache/spark/pull/33935#issuecomment-915062346


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47580/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #33935: [SPARK-36692][CORE] Improve Error statement when requesting thread dump while executor already stopped

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33935:
URL: https://github.com/apache/spark/pull/33935#discussion_r704157864



##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -694,8 +694,14 @@ class SparkContext(config: SparkConf) extends Logging {
       if (executorId == SparkContext.DRIVER_IDENTIFIER) {
         Some(Utils.getThreadDump())
       } else {
-        val endpointRef = env.blockManager.master.getExecutorEndpointRef(executorId).get
-        Some(endpointRef.askSync[Array[ThreadStackTrace]](TriggerThreadDump))
+        env.blockManager.master.getExecutorEndpointRef(executorId) match {
+          case Some(endpointRef) =>
+            Some(endpointRef.askSync[Array[ThreadStackTrace]](TriggerThreadDump))
+          case None =>
+            logWarning(s"Executor $executorId might already have stopped and" +
+              s" can not request thread dump from it.")

Review comment:
       ```suggestion
                 " can not request thread dump from it.")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33935: [SPARK-36692][CORE] Improve Error statement when requesting thread dump while executor already stopped

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33935:
URL: https://github.com/apache/spark/pull/33935#issuecomment-915095667


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47580/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #33935: [SPARK-36692][CORE] Improve Error statement when requesting thread dump while executor already stopped

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33935:
URL: https://github.com/apache/spark/pull/33935#issuecomment-915017208


   ping @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #33935: [SPARK-36692][CORE] Improve Error statement when requesting thread dump while executor already stopped

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33935:
URL: https://github.com/apache/spark/pull/33935#issuecomment-915678666


   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33935: [SPARK-36692][CORE] Improve Error statement when requesting thread dump while executor already stopped

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33935:
URL: https://github.com/apache/spark/pull/33935#issuecomment-915095667






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33935: [SPARK-36692][CORE] Improve Error statement when requesting thread dump while executor already stopped

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33935:
URL: https://github.com/apache/spark/pull/33935#issuecomment-915031718


   **[Test build #143078 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143078/testReport)** for PR 33935 at commit [`d4b0bd6`](https://github.com/apache/spark/commit/d4b0bd68c08430978654a766fdb10e1930bdc5d8).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33935: [SPARK-36692][CORE] Improve Error statement when requesting thread dump while executor already stopped

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33935:
URL: https://github.com/apache/spark/pull/33935#issuecomment-915031718


   **[Test build #143078 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143078/testReport)** for PR 33935 at commit [`d4b0bd6`](https://github.com/apache/spark/commit/d4b0bd68c08430978654a766fdb10e1930bdc5d8).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #33935: [SPARK-36692][CORE] Improve Error statement when requesting thread dump while executor already stopped

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #33935:
URL: https://github.com/apache/spark/pull/33935


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33935: [SPARK-36692][CORE] Improve Error statement when requesting thread dump while executor already stopped

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33935:
URL: https://github.com/apache/spark/pull/33935#issuecomment-915153315


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143078/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org