You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/10/17 18:23:24 UTC

[GitHub] [commons-lang] Rushi98 commented on a change in pull request #815: LANG-1676 add another case in RangeTest:testIsOverlappedBy

Rushi98 commented on a change in pull request #815:
URL: https://github.com/apache/commons-lang/pull/815#discussion_r730455909



##########
File path: src/test/java/org/apache/commons/lang3/RangeTest.java
##########
@@ -306,6 +306,7 @@ public void testIsOverlappedBy() {
 
         // easy inside range
         assertTrue(intRange.isOverlappedBy(Range.between(12, 18)));
+        assertTrue(intRange.isOverlappedBy(Range.between(5, 25)));

Review comment:
       Hi @garydgregory 
   Your [change](https://github.com/apache/commons-lang/commit/ad37cca1caef01cb3d54e479b42d44346f93ac2b#diff-db25bb249ffd66485de1d3a2b394672c04a3554b53d284cef83fa291f7252a51R332) does make the test case clearer. Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org