You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/16 15:00:14 UTC
[GitHub] [incubator-druid] leventov commented on a change in pull request
#8086: add checkstyle to forbid unecessary use of Class.getCanonicalName
leventov commented on a change in pull request #8086: add checkstyle to forbid unecessary use of Class.getCanonicalName
URL: https://github.com/apache/incubator-druid/pull/8086#discussion_r303959138
##########
File path: codestyle/checkstyle.xml
##########
@@ -319,5 +319,11 @@ codestyle/checkstyle.xml. "/>
<module name="LocalFinalVariableName">
<property name="format" value="^[a-z_]*[a-z0-9][a-zA-Z0-9_]*$"/>
</module>
+
+ <module name="Regexp">
Review comment:
Could you use [forbidden-apis](https://github.com/apache/incubator-druid/blob/master/codestyle/druid-forbidden-apis.txt) which is a native tool for this type of prohibition?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org