You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "metesynnada (via GitHub)" <gi...@apache.org> on 2024/01/05 11:57:41 UTC

[PR] Add early exit to for the impossible Aggregative joins [arrow-datafusion]

metesynnada opened a new pull request, #8759:
URL: https://github.com/apache/arrow-datafusion/pull/8759

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   ## Rationale for this change
   
   When we couldn't convert an incomplete Aggregative join, this candidate branch should be invalidated.
   
   
   ## What changes are included in this PR?
   
   Early exit from the recursion in `find_incomplete_joins_and_change`.
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add early exit to for the impossible Aggregative joins [arrow-datafusion]

Posted by "metesynnada (via GitHub)" <gi...@apache.org>.
metesynnada closed pull request #8759: Add early exit to for the impossible Aggregative joins
URL: https://github.com/apache/arrow-datafusion/pull/8759


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add early exit to for the impossible Aggregative joins [arrow-datafusion]

Posted by "metesynnada (via GitHub)" <gi...@apache.org>.
metesynnada commented on PR #8759:
URL: https://github.com/apache/arrow-datafusion/pull/8759#issuecomment-1878556427

   We accidentally opened this from our fork.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add early exit to for the impossible Aggregative joins [arrow-datafusion]

Posted by "metesynnada (via GitHub)" <gi...@apache.org>.
metesynnada closed pull request #8759: Add early exit to for the impossible Aggregative joins
URL: https://github.com/apache/arrow-datafusion/pull/8759


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org