You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/13 13:39:12 UTC
[GitHub] [airflow] mjpieters opened a new pull request #12342: Refactor root logger handling in task run
mjpieters opened a new pull request #12342:
URL: https://github.com/apache/airflow/pull/12342
- Use a context manager to encapsulate task logging setup and teardown
- Create a copy, not a reference, of the handlers list
- Remove logging.shutdown(), it simply should not be called
Closes #12090
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #12342: Refactor root logger handling in task run
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #12342:
URL: https://github.com/apache/airflow/pull/12342
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12342: Refactor root logger handling in task run
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12342:
URL: https://github.com/apache/airflow/pull/12342#issuecomment-726918266
Thanks :) -- You beat me to it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12342: Refactor root logger handling in task run
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12342:
URL: https://github.com/apache/airflow/pull/12342#issuecomment-726920840
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org