[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #614: MINIFICPP-732 - Add property to expose librdkafka "debug" values for …

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #614: MINIFICPP-732 - Add property to expose librdkafka "debug" values for …
URL: https://github.com/apache/nifi-minifi-cpp/pull/614#discussion_r305539265
 
 

 ##########
 File path: extensions/librdkafka/PublishKafka.cpp
 ##########
 @@ -79,6 +79,7 @@ core::Property PublishKafka::KerberosKeytabPath("Kerberos Keytab Path",
 core::Property PublishKafka::MessageKeyField("Message Key Field", "The name of a field in the Input Records that should be used as the Key for the Kafka message.\n"
                                              "Supports Expression Language: true (will be evaluated using flow file attributes)",
                                              "");
+core::Property PublishKafka::DebugContexts("Debug contexts", "A comma-separated list of debug contexts to enable. Including: generic, broker, topic, metadata, feature, queue, msg, protocol, cgrp, security, fetch, interceptor, plugin, consumer, admin, eos, all", "");
 
 Review comment:
   @nghiaxlee what you say makes perfect sense, NiFI provides ListValidator for the given purpose:
   https://github.com/apache/nifi/blob/master/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/processor/util/StandardValidators.java#569
   
   Although we don't have this functionality in MiNiFi at the moment, will create a follow-up Jira soon. I think the scope of this ticket is unquestionably small to cover this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services