[GitHub] sv2000 commented on a change in pull request #2559: GOBBLIN-687: Pass TopologySpec map to DagManager to allow reuse of Sp…

[GitBox <gi...@apache.org>]

sv2000 commented on a change in pull request #2559: GOBBLIN-687: Pass TopologySpec map to DagManager to allow reuse of Sp…
URL: https://github.com/apache/incubator-gobblin/pull/2559#discussion_r258622933
 
 

 ##########
 File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java
 ##########
 @@ -354,7 +354,10 @@ private void handleLeadershipChange(NotificationContext changeContext) {
       }
 
       if (this.isDagManagerEnabled) {
-        this.dagManager.setActive(true);
+        //Activate DagManager only if TopologyCatalog is initialized. If not; skip activation.
+        if (this.topologyCatalog.getInitComplete().getCount() <= 0) {
 
 Review comment:
   Changed it to == 0. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services