Re: [PR] Maven migration, refactored, plus maven build changes since then. [xalan-java]

["jkesselm (via GitHub)" <gi...@apache.org>]

jkesselm commented on PR #110:
URL: https://github.com/apache/xalan-java/pull/110#issuecomment-1792923960

   In the absense of review: 
   
   Given that the executable build appears to be correct, I'm looking at subtler differences betweeen the Maven and Ant `build/` output
   
   1) In the jarfile for the samples
   - Jarfile is renamed from xalansamples.jar to samples.jar. I think that's OK; could be persuaded to change it.
   - Samples are moved into packages. That's deliberate, but their documentation and invocation (if any?) should be updated to reflect that.
   - Maven version of samples.jar includes clases that the Ant build put in separate sample jarfiles. We could consider producing those targeted archives:
   * Ant xsltcapplet.jar: TransformApplet
   * Ant xsltcbrazil;jar: TransformerHandler
   * Ant xsltcejb.jar:  TransformBean, TransformHome, TransformRemote, TransformServlet
   * Ant xsltcservlet.jar: CompileServlet, TransformServlet
   * Ant xalanservlet.war:  ApplyXSLT, ApplyXSLTException, ApplyXSLTListener, ApplyXSLTProperties, DefaultApplyXSLTProperties, OrderedProps, PIA, SimpleXSLTServlet, UseStylesheetParamServlet, XSLTServletWithParams. This web-archive should also include the media.properties file,, a copy of xalan.jar, and the xml, xsl, and jsp files to run that web archive.  Note that the jsp file probably needs to be updated to reflect new servlet/ package.
    
   Should I fix the Maven build to produce these isolated XSLTC sample jar/war files, or is nobody ever really going to care? (Arguably I should produce the .war file, at least, since it needs data files/directory structure not included in the overall samples jarfile.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org