[jira] Commented: (HARMONY-474) Bugs in org.apache.harmony.text.tests.java.text.NumberFormatTest

["Stepan Mishura (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/HARMONY-474?page=comments#action_12412502 ] 

Stepan Mishura commented on HARMONY-474:
----------------------------------------

Richard , according to JUnit's javadoc: assertEquals(String message, String expected, String actual) 

So the second param is expected string and the third param is returned string. But IMO assertEquals in your patch doesn't follow this:
For example,
assertEquals("Wrong result BI3: " + out, out.toString(), "9,223,372,036,854,775,808");

Thanks,
Stepan.

> Bugs in org.apache.harmony.text.tests.java.text.NumberFormatTest
> ----------------------------------------------------------------
>
>          Key: HARMONY-474
>          URL: http://issues.apache.org/jira/browse/HARMONY-474
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Richard Liang
>     Assignee: Stepan Mishura
>     Priority: Minor
>  Attachments: text.make.diff, text.src.diff
>
> Hello,
> There are some bugs in this test. I will attache the patch soon. Thanks a lot.
> Best regards,
> Richard

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira