[GitHub] [airflow] o-nikolas commented on a diff in pull request #24554: Add SqsBatchSensor

[GitBox <gi...@apache.org>]

o-nikolas commented on code in PR #24554:
URL: https://github.com/apache/airflow/pull/24554#discussion_r902954192


##########
airflow/providers/amazon/aws/sensors/sqs.py:
##########
@@ -215,3 +229,68 @@ def __init__(self, *args, **kwargs):
             stacklevel=2,
         )
         super().__init__(*args, **kwargs)
+
+
+class SqsBatchSensor(SqsSensor):
+    """
+    Get messages from an Amazon SQS queue in batches and then delete the retrieved messages from the queue.
+    If deletion of messages fails an AirflowException is thrown. Otherwise, all messages
+    are pushed through XCom with the key ``messages``.
+
+    This sensor is identical to SqsSensor, except that SqsSensor performs one and only one SQS call
+    per poke, which limits the result to a maximum of 10 messages, while SqsBatchSensor performs multiple
+    SQS API calls per poke and combines the results into one list.
+
+    .. seealso::
+        For more information on how to use this sensor, take a look at the guide:
+        :ref:`howto/sensor:SqsBatchSensor`
+
+    :param num_batches: The number of times the sensor will call the SQS API to receive messages (default: 1)

Review Comment:
   The default behaviour of this class effectively mimics the `SqsSensor` and much of the poke method below is duplicate code from the `SqsSensor.poke` except wrapped in a for loop.
   
   Do we really need this new class? It might be more straightforward and less duplicate code to just add `num_batches` to `SqsSensor` (with a default of 1 to maintain current behaviour) as a new optional kwarg and teach `SqsSensor` to do batches.
   
   WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org