You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2014/12/25 09:57:25 UTC

Review Request 29417: LENS-167: Add compile time type checks in event service

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29417/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-167
    https://issues.apache.org/jira/browse/LENS-167


Repository: lens


Description
-------

Added generics


Diffs
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 600406395f2c3fb067b73d7737ad4d4ce36ffbd0 
  lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java aadd0e1b0af3efe1b975bfa378516f7a0564336c 

Diff: https://reviews.apache.org/r/29417/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 29417: LENS-167: Add compile time type checks in event service

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29417/#review66124
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Dec. 25, 2014, 9:16 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29417/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2014, 9:16 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-167
>     https://issues.apache.org/jira/browse/LENS-167
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Added generics
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 600406395f2c3fb067b73d7737ad4d4ce36ffbd0 
>   lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java aadd0e1b0af3efe1b975bfa378516f7a0564336c 
> 
> Diff: https://reviews.apache.org/r/29417/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.206s]
> [INFO] Lens .............................................. SUCCESS [2.955s]
> [INFO] Lens API .......................................... SUCCESS [6.845s]
> [INFO] Lens API for server and extensions ................ SUCCESS [4.424s]
> [INFO] Lens Cube ......................................... SUCCESS [7:00.915s]
> [INFO] Lens DB storage ................................... SUCCESS [12.473s]
> [INFO] Lens Query Library ................................ SUCCESS [5.112s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.609s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [3.304s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [29.381s]
> [INFO] Lens Server ....................................... SUCCESS [4:52.655s]
> [INFO] Lens client ....................................... SUCCESS [22.611s]
> [INFO] Lens CLI .......................................... SUCCESS [2:02.227s]
> [INFO] Lens Examples ..................................... SUCCESS [1.014s]
> [INFO] Lens Distribution ................................. SUCCESS [6.052s]
> [INFO] Lens Client Distribution .......................... SUCCESS [5.877s]
> [INFO] Lens ML Lib ....................................... SUCCESS [48.337s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:17.039s
> [INFO] Finished at: Thu Dec 25 09:14:53 UTC 2014
> [INFO] Final Memory: 112M/1308M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 29417: LENS-167: Add compile time type checks in event service

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29417/
-----------------------------------------------------------

(Updated Dec. 25, 2014, 9:16 a.m.)


Review request for lens.


Bugs: LENS-167
    https://issues.apache.org/jira/browse/LENS-167


Repository: lens


Description
-------

Added generics


Diffs
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 600406395f2c3fb067b73d7737ad4d4ce36ffbd0 
  lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java aadd0e1b0af3efe1b975bfa378516f7a0564336c 

Diff: https://reviews.apache.org/r/29417/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.206s]
[INFO] Lens .............................................. SUCCESS [2.955s]
[INFO] Lens API .......................................... SUCCESS [6.845s]
[INFO] Lens API for server and extensions ................ SUCCESS [4.424s]
[INFO] Lens Cube ......................................... SUCCESS [7:00.915s]
[INFO] Lens DB storage ................................... SUCCESS [12.473s]
[INFO] Lens Query Library ................................ SUCCESS [5.112s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.609s]
[INFO] Lens Driver for Cloudera Impala ................... SUCCESS [3.304s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [29.381s]
[INFO] Lens Server ....................................... SUCCESS [4:52.655s]
[INFO] Lens client ....................................... SUCCESS [22.611s]
[INFO] Lens CLI .......................................... SUCCESS [2:02.227s]
[INFO] Lens Examples ..................................... SUCCESS [1.014s]
[INFO] Lens Distribution ................................. SUCCESS [6.052s]
[INFO] Lens Client Distribution .......................... SUCCESS [5.877s]
[INFO] Lens ML Lib ....................................... SUCCESS [48.337s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:17.039s
[INFO] Finished at: Thu Dec 25 09:14:53 UTC 2014
[INFO] Final Memory: 112M/1308M
[INFO] ------------------------------------------------------------------------
 


Thanks,

Rajat Khandelwal