You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jason Gerlowski (JIRA)" <ji...@apache.org> on 2015/12/24 19:10:49 UTC
[jira] [Comment Edited] (SOLR-8462) Improve error reporting for
/stream handler
[ https://issues.apache.org/jira/browse/SOLR-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071158#comment-15071158 ]
Jason Gerlowski edited comment on SOLR-8462 at 12/24/15 6:09 PM:
-----------------------------------------------------------------
Attached patch addresses case (1) from the description above. Haven't yet set out at improving case (2), though I will in a subsequent patch.
Tests all pass locally for me.
was (Author: gerlowskija):
Attached patch uses opts to use the class name of the exception if the message is null. Tests all pass locally for me.
> Improve error reporting for /stream handler
> -------------------------------------------
>
> Key: SOLR-8462
> URL: https://issues.apache.org/jira/browse/SOLR-8462
> Project: Solr
> Issue Type: Improvement
> Affects Versions: Trunk
> Reporter: Jason Gerlowski
> Priority: Trivial
> Fix For: Trunk
>
> Attachments: SOLR-8462.patch
>
>
> Currently, the /stream request handler reports errors by adding an "EXCEPTION" name/value pair on a tuple in the TupleStream where the error arose. The "value" in this name/value pair is the message attached to the exception.
> This works well in most instances, however it could be better in a few ways:
> 1.) Not all exceptions have messages. For instance, {{NullPointerExceptions}} and other run time exceptions fall into this category. This causes the /stream handler to return the relatively unhelpful value: {"EXCEPTION":null,"EOF":true}. The /stream handler should make sure the exception has a message, and if not, it should report some other information about the error (exception class name?).
> 2.) There are some common error cases that can arise from mis-use of the API. For instance, if the 'expr' parameter is missing. Detecting and handling these cases specifically would allow users to get back clearer, more useful error messages.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org