You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rajesh Battala <ra...@citrix.com> on 2013/04/17 13:59:04 UTC
Review Request: Fixed CLOUDSTACK-1849 [AWS Style Health Checks] Creation of
LB Health Check policy fails if the value of "Unhealthy Threshold"
parameter is 3 or more.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10570/
-----------------------------------------------------------
Review request for cloudstack, Murali Reddy, Vijay Venkatachalam, and Ram Ganesh.
Description
-------
By default monitor retires value is '3'.
Fixed the issue, while creating the monitor setting the retires value in monitor object to max of (HealthcheckThresshold , UnhealthThresshold) + 1
Diffs
-----
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java b82176b
Diff: https://reviews.apache.org/r/10570/diff/
Testing
-------
1. Verified the creation of monitor with params value more than '3' monitor is getting created.
2. verified the monitor properties in the Netscaler properties are saved accordingly.
3. Verified creating the monitor for TCP/HTTP types.
4. deletion of monitor works well.
Thanks,
Rajesh Battala
Re: Review Request: Fixed CLOUDSTACK-1849 [AWS Style Health Checks] Creation
of LB Health Check policy fails if the value of "Unhealthy Threshold"
parameter is 3 or more.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10570/#review20113
-----------------------------------------------------------
Commit c8e3fff6e43954bdd0c33aabcd0c17fa3799c4f3 in branch refs/heads/master from Sateesh Chodapuneedi <sa...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c8e3fff ]
CLOUDSTACK-1849 Creation of LB Health Check policy fails if the value of Unhealthy Threshold parameter is 3 or more.
Signed-off-by: Sateesh Chodapuneedi <sa...@apache.org>
- ASF Subversion and Git Services
On April 17, 2013, 11:59 a.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10570/
> -----------------------------------------------------------
>
> (Updated April 17, 2013, 11:59 a.m.)
>
>
> Review request for cloudstack, Murali Reddy, Vijay Venkatachalam, and Ram Ganesh.
>
>
> Description
> -------
>
> By default monitor retires value is '3'.
> Fixed the issue, while creating the monitor setting the retires value in monitor object to max of (HealthcheckThresshold , UnhealthThresshold) + 1
>
>
> Diffs
> -----
>
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java b82176b
>
> Diff: https://reviews.apache.org/r/10570/diff/
>
>
> Testing
> -------
>
> 1. Verified the creation of monitor with params value more than '3' monitor is getting created.
> 2. verified the monitor properties in the Netscaler properties are saved accordingly.
> 3. Verified creating the monitor for TCP/HTTP types.
> 4. deletion of monitor works well.
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request: Fixed CLOUDSTACK-1849 [AWS Style Health Checks] Creation
of LB Health Check policy fails if the value of "Unhealthy Threshold"
parameter is 3 or more.
Posted by Ram Ganesh <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10570/#review19619
-----------------------------------------------------------
Ship it!
Ship It!
- Ram Ganesh
On April 17, 2013, 11:59 a.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10570/
> -----------------------------------------------------------
>
> (Updated April 17, 2013, 11:59 a.m.)
>
>
> Review request for cloudstack, Murali Reddy, Vijay Venkatachalam, and Ram Ganesh.
>
>
> Description
> -------
>
> By default monitor retires value is '3'.
> Fixed the issue, while creating the monitor setting the retires value in monitor object to max of (HealthcheckThresshold , UnhealthThresshold) + 1
>
>
> Diffs
> -----
>
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java b82176b
>
> Diff: https://reviews.apache.org/r/10570/diff/
>
>
> Testing
> -------
>
> 1. Verified the creation of monitor with params value more than '3' monitor is getting created.
> 2. verified the monitor properties in the Netscaler properties are saved accordingly.
> 3. Verified creating the monitor for TCP/HTTP types.
> 4. deletion of monitor works well.
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request: Fixed CLOUDSTACK-1849 [AWS Style Health Checks] Creation
of LB Health Check policy fails if the value of "Unhealthy Threshold"
parameter is 3 or more.
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10570/#review20114
-----------------------------------------------------------
Ship it!
Commit c8e3fff6e43954bdd0c33aabcd0c17fa3799c4f3 in branch refs/heads/master
- Sateesh Chodapuneedi
On April 17, 2013, 11:59 a.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10570/
> -----------------------------------------------------------
>
> (Updated April 17, 2013, 11:59 a.m.)
>
>
> Review request for cloudstack, Murali Reddy, Vijay Venkatachalam, and Ram Ganesh.
>
>
> Description
> -------
>
> By default monitor retires value is '3'.
> Fixed the issue, while creating the monitor setting the retires value in monitor object to max of (HealthcheckThresshold , UnhealthThresshold) + 1
>
>
> Diffs
> -----
>
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java b82176b
>
> Diff: https://reviews.apache.org/r/10570/diff/
>
>
> Testing
> -------
>
> 1. Verified the creation of monitor with params value more than '3' monitor is getting created.
> 2. verified the monitor properties in the Netscaler properties are saved accordingly.
> 3. Verified creating the monitor for TCP/HTTP types.
> 4. deletion of monitor works well.
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request: Fixed CLOUDSTACK-1849 [AWS Style Health Checks] Creation
of LB Health Check policy fails if the value of "Unhealthy Threshold"
parameter is 3 or more.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10570/#review20141
-----------------------------------------------------------
Commit c8e3fff6e43954bdd0c33aabcd0c17fa3799c4f3 in branch refs/heads/internallb from Sateesh Chodapuneedi <sa...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c8e3fff ]
CLOUDSTACK-1849 Creation of LB Health Check policy fails if the value of Unhealthy Threshold parameter is 3 or more.
Signed-off-by: Sateesh Chodapuneedi <sa...@apache.org>
- ASF Subversion and Git Services
On April 17, 2013, 11:59 a.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10570/
> -----------------------------------------------------------
>
> (Updated April 17, 2013, 11:59 a.m.)
>
>
> Review request for cloudstack, Murali Reddy, Vijay Venkatachalam, and Ram Ganesh.
>
>
> Description
> -------
>
> By default monitor retires value is '3'.
> Fixed the issue, while creating the monitor setting the retires value in monitor object to max of (HealthcheckThresshold , UnhealthThresshold) + 1
>
>
> Diffs
> -----
>
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java b82176b
>
> Diff: https://reviews.apache.org/r/10570/diff/
>
>
> Testing
> -------
>
> 1. Verified the creation of monitor with params value more than '3' monitor is getting created.
> 2. verified the monitor properties in the Netscaler properties are saved accordingly.
> 3. Verified creating the monitor for TCP/HTTP types.
> 4. deletion of monitor works well.
>
>
> Thanks,
>
> Rajesh Battala
>
>