You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/06/19 20:37:38 UTC

Review Request 60206: AMBARI-21281 Code refactoring: rename RU_TASKS Stagewrapper type to upgrade tasks

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60206/
-----------------------------------------------------------

Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-21281
    https://issues.apache.org/jira/browse/AMBARI-21281


Repository: ambari


Description
-------

Code refactoring: rename RU_TASKS Stagewrapper type to upgrade tasks


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 2f6ffc1 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 8e59602 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java 960a04c 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 51bd168 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java 288f98a 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 014ab42 


Diff: https://reviews.apache.org/r/60206/diff/1/


Testing
-------

existing unit tests.


Thanks,

Di Li


Re: Review Request 60206: AMBARI-21281 Code refactoring: rename RU_TASKS Stagewrapper type to upgrade tasks

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60206/#review178307
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On June 19, 2017, 8:37 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60206/
> -----------------------------------------------------------
> 
> (Updated June 19, 2017, 8:37 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21281
>     https://issues.apache.org/jira/browse/AMBARI-21281
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Code refactoring: rename RU_TASKS Stagewrapper type to upgrade tasks
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 2f6ffc1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 8e59602 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java 960a04c 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 51bd168 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java 288f98a 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 014ab42 
> 
> 
> Diff: https://reviews.apache.org/r/60206/diff/1/
> 
> 
> Testing
> -------
> 
> existing unit tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>


Re: Review Request 60206: AMBARI-21281 Code refactoring: rename RU_TASKS Stagewrapper type to upgrade tasks

Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60206/#review178317
-----------------------------------------------------------


Ship it!




Ship It!

- Tim Thorpe


On June 19, 2017, 8:37 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60206/
> -----------------------------------------------------------
> 
> (Updated June 19, 2017, 8:37 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21281
>     https://issues.apache.org/jira/browse/AMBARI-21281
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Code refactoring: rename RU_TASKS Stagewrapper type to upgrade tasks
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 2f6ffc1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 8e59602 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java 960a04c 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java 51bd168 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java 288f98a 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 014ab42 
> 
> 
> Diff: https://reviews.apache.org/r/60206/diff/1/
> 
> 
> Testing
> -------
> 
> existing unit tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>