You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "milenkovicm (via GitHub)" <gi...@apache.org> on 2025/11/13 16:35:47 UTC

[I] Inconsistent `datafusion.sql_parser.enable_ident_normalization=false` behaviour [datafusion]

milenkovicm opened a new issue, #18675:
URL: https://github.com/apache/datafusion/issues/18675

   ### Describe the bug
   
   There is inconsistency with  `datafusion.sql_parser.enable_ident_normalization`, when set to `false`, disabling normalisation. 
   
   ### To Reproduce
   
   ```rust
   use datafusion::{error::Result, prelude::SessionContext};
   
   #[tokio::main]
   async fn main() -> Result<()> {
       let ctx = SessionContext::new();
   
       ctx.sql("SET datafusion.sql_parser.enable_ident_normalization=false")
           .await?
           .collect()
           .await?;
   
       ctx.register_csv(
           "DATA",
           "data.csv",
           Default::default(),
       )
       .await?;
   
       ctx.sql("select * from DATA").await?.show().await?;
   
       Ok(())
   }
   
   ```
   
   (note all caps table name `DATA`)
   
   will fail with error: 
   
   
   ```
   Error: Diagnostic(Diagnostic { kind: Error, message: "table 'DATA' not found", span: Some(Span(Location(1,15)..Location(1,19))), notes: [], helps: [] }, Plan("table 'datafusion.public.DATA' not found"))
   ```
   
   ### Expected behavior
   
   Expected behaviour would be to find table `datafusion.public.DATA`.
   
   I'm not sure if DATA (name) should be normalised to lower-case, I would argue not, but some consistency is needed.
   
   ### Additional context
   
   Issue starts at `register_csv` table (actually, `register_table`) where table name is converted to lover case at: 
   
   https://github.com/milenkovicm/datafusion/blob/377c0fce481d561d58e3a6fad2dca18cb1d58384/datafusion/core/src/execution/context/mod.rs#L1609-L1610
   
   root of the  issue is at: 
   
   https://github.com/apache/datafusion/blob/377c0fce481d561d58e3a6fad2dca18cb1d58384/datafusion/common/src/table_reference.rs#L281
   
   where normalisation is enforced as second parameter is `false` (based on docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Inconsistent `datafusion.sql_parser.enable_ident_normalization=false` behaviour [datafusion]

Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on issue #18675:
URL: https://github.com/apache/datafusion/issues/18675#issuecomment-3533725221

   I'm closing this issue for now 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Inconsistent `datafusion.sql_parser.enable_ident_normalization=false` behaviour [datafusion]

Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm closed issue #18675: Inconsistent `datafusion.sql_parser.enable_ident_normalization=false` behaviour
URL: https://github.com/apache/datafusion/issues/18675


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Inconsistent `datafusion.sql_parser.enable_ident_normalization=false` behaviour [datafusion]

Posted by "Yuvraj-cyborg (via GitHub)" <gi...@apache.org>.
Yuvraj-cyborg commented on issue #18675:
URL: https://github.com/apache/datafusion/issues/18675#issuecomment-3531652103

   @milenkovicm Dropped the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Inconsistent `datafusion.sql_parser.enable_ident_normalization=false` behaviour [datafusion]

Posted by "Yuvraj-cyborg (via GitHub)" <gi...@apache.org>.
Yuvraj-cyborg commented on issue #18675:
URL: https://github.com/apache/datafusion/issues/18675#issuecomment-3529289935

   Hey @milenkovicm can I take on this issue ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Inconsistent `datafusion.sql_parser.enable_ident_normalization=false` behaviour [datafusion]

Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on issue #18675:
URL: https://github.com/apache/datafusion/issues/18675#issuecomment-3529861810

   Please do @Yuvraj-cyborg 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Inconsistent `datafusion.sql_parser.enable_ident_normalization=false` behaviour [datafusion]

Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on issue #18675:
URL: https://github.com/apache/datafusion/issues/18675#issuecomment-3532062696

   looks like there is similar problem at 167baf718278112d427910a0296f366909bc3384


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Inconsistent `datafusion.sql_parser.enable_ident_normalization=false` behaviour [datafusion]

Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on issue #18675:
URL: https://github.com/apache/datafusion/issues/18675#issuecomment-3533633956

   @Yuvraj-cyborg I'm not sure if this could be fixed without big impact on the public API or behaviour change. There is also a valid workaround.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org