You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/04/28 10:50:48 UTC
[Issue 124760] New: crashes after moving merged shapes
https://issues.apache.org/ooo/show_bug.cgi?id=124760
Issue ID: 124760
Issue Type: DEFECT
Summary: crashes after moving merged shapes
Product: Draw
Version: 4.0.1
Hardware: All
OS: Windows 7
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: formatting
Assignee: issues@openoffice.apache.org
Reporter: martinpeckhaus@gmx.de
Created attachment 83286
--> https://issues.apache.org/ooo/attachment.cgi?id=83286&action=edit
steps
i have more than one shape (e.g. a rectangle and an oval) which i want to
merge.
after selecting the shapes and merging it, i only can move the new object 99
steps with the arrow keys (any directions). the 100th move causes a crash.
- this only happens if i don't release the new object once after merging
- this doesn't happen, when i release the new object after merging it. after
selecting it again i can move it countless times without crashing
- this doesn't happen, when i release the new object after moving it between 0
and 99 movements. after selecting it again i can move it countless times
without crashing
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124760] crashes after moving merged shapes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124760
Edwin Sharp <el...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |elish@apache.org
--- Comment #6 from Edwin Sharp <el...@apache.org> ---
Can not reproduce
AOO410m18(Build:9764) - Rev. 1589052
2014-04-22 12:11 - Linux x86_64
Debian
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124760] crashes after moving merged shapes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124760
--- Comment #4 from martinpeckhaus@gmx.de ---
I reduced the redo steps to 10 and it crashes now after 10 steps.
It also happens with Intersect and Subtract.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124760] crashes after moving merged shapes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124760
--- Comment #10 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1590709 into trunk:
i124760 ensure that only the created object is selected
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 124760] crashes after moving merged shapes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124760
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|4.0.1 |OOo 3.3 or older
--- Comment #5 from Oliver-Rainer Wittmann <or...@apache.org> ---
setting field Version back to 'OOo 3.3.0 or older' as the defect already occurs
in former OpenOffice version.
Documentation for field Version is "Version - The oldest version of the
software the issue can be found in."
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124760] crashes after moving merged shapes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124760
Andre <aw...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
CC| |awf.aoo@googlemail.com
Ever confirmed|0 |1
--- Comment #1 from Andre <aw...@googlemail.com> ---
I didn't count the number of steps but I can confirm the crash on trunk.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124760] crashes after moving merged shapes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124760
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Armin.Le.Grand@me.com
--- Comment #3 from Armin Le Grand <Ar...@me.com> ---
Yes, I can also reproduce this. What happens after 99 steps is that the oldest
undo action gets deleted when the default of 100 undo steps is active. Could
you please check in tools/options/memory if this is the case?
It should be, when I reduce to 10 steps it crashes after 10 steps. Strange is
that it depends on reselections; I would guess that one of the objects before
the merge operation is still used somewhere in the core (selection?) when it
gets destroyed from the deletion of the oldes undo (which will reference these
objects and thus destroy them)...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124760] crashes after moving merged shapes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124760
--- Comment #8 from Armin Le Grand <Ar...@me.com> ---
Checked the whole object lifetime in the used undo stack, all okay, no error
found. Added setting the selection to empty when selecting the new object, that
makes it work. To find out the reason for the failure I digged into the
selection correction stuff and found that there still is one part where three
objctes are hold in the selection, it's the maAllMarkedObjects member of the
sdr::ViewSelection. This is used in building the transitive hull of marked
objects (see GetTransitiveHullOfMarkedObjects) to be able to handle all cases
of ImpBroadcastEdgesOfMarkedNodes. It uses RTTI (here old ptr_cast) and that
crashes on the correctly deleted objects. Not sure right now, but this can
probably not even happen in aw080 anymore, sigh.
Update: Checked that, can indeed not happen, the handling of the connector
stuff has completely changed/simplified, there is no sdr::ViewSelection anymore
To fix in the current code it is best to do what should have happened from the
beginning: Set the correct selection in the operation. Adding that.
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 124760] crashes after moving merged shapes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124760
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ACCEPTED |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |4.2.0
--- Comment #9 from Armin Le Grand <Ar...@me.com> ---
Okay, done.
--
You are receiving this mail because:
You are watching all issue changes.
[Issue 124760] crashes after moving merged shapes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124760
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |ACCEPTED
Assignee|issues@openoffice.apache.or |Armin.Le.Grand@me.com
|g |
--- Comment #7 from Armin Le Grand <Ar...@me.com> ---
It only happens when not re-selecting the created shape, but directly start to
move it (with cursor keys is fastest).
The undo stack gets quite sme actions for creating this (convert objects to
polygon objects, merge, insert result object, delete source objects), but works
well. Completely traveling through undo/redo works as intended.
Thus it must have to do with the undo stack deletion together with the
selection. Looking deeper since the selection looks okay after the action; only
one object is selected since the selection gets 'corrected' afterwards by
excluding all objects which are not inserted to the model currently (see
SdrMarkView::CheckMarked()).
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124760] crashes after moving merged shapes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124760
martinpeckhaus@gmx.de changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|OOo 3.3 or older |4.0.1
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 124760] crashes after moving merged shapes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124760
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|4.0.1 |OOo 3.3 or older
--- Comment #2 from Oliver-Rainer Wittmann <or...@apache.org> ---
I reproduce the crash under Windows 7 with OOo 3.0.0 and OOo 3.3.0. I also did
not count the moves - I just hold the arrow key
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.