You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/21 15:21:39 UTC
[GitHub] [incubator-druid] himanshug opened a new pull request #8359:
Logging emitter to publish query and other metric events as valid json
objects
himanshug opened a new pull request #8359: Logging emitter to publish query and other metric events as valid json objects
URL: https://github.com/apache/incubator-druid/pull/8359
### Description
This patch enables pushing druid metrics in log as valid json objects which are supported out of the box by various systems used for storing and searching logs. This aids us in investigating various issues in Druid cluster.
It has following changes.
- LoggingEmitter is modified to emit `jsonMapper.writeValueAsString(event)` instead of `format("Event [%s]", jsonMapper.writeValueAsString(event))` .
- QueryMetrics puts the query context into metric event as is instead of converting it to String.
- `EmittingRequestLoggerProvider` uses only available `DefaultRequestLogEventBuilderFactory` by default when publishing request logs using the emitter.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] been tested in a Druid cluster.
<hr>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org