[jira] [Commented] (TEZ-1692) Reduce code duplication between TezMapredSplitsGrouper and TezMapreduceSplitsGrouper

["Bikas Saha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178779#comment-14178779 ] 

Bikas Saha commented on TEZ-1692:
---------------------------------

The only way I could think off for reducing code duplication was to wrap the splits in another wrapper object so that mapred and mapreduce splits could be handled in the same code via the wrapper. But that would increase the memory foot print for large number of splits. So I chose code duplication over the increase in memory.
That being said, if some refactoring could be done without increasing memory then it would be really good to reduce code duplication.

> Reduce code duplication between TezMapredSplitsGrouper and TezMapreduceSplitsGrouper
> ------------------------------------------------------------------------------------
>
>                 Key: TEZ-1692
>                 URL: https://issues.apache.org/jira/browse/TEZ-1692
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>
> The two are almost identical - with lots of repeated logic. The main difference being the mapred / mapreduce InputSplit being grouped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)