You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/07/23 20:06:21 UTC
[PR] ci: retry Codecov upload to survive flaky CLI signature verification [texera]
aglinxinyuan opened a new pull request, #6836:
URL: https://github.com/apache/texera/pull/6836
### What changes were proposed in this PR?
Reported on #6800 ("codecov is not updating"). The deferred `Codecov Upload` workflow re-downloads and GPG-verifies the Codecov CLI on every leg, and that runtime key import / signature check is **intermittently flaky**:
```
gpg: no valid OpenPGP data found
gpg: Can't check signature: No public key
==> Could not verify signature. Please contact Codecov if problem continues
Exiting... # exit code 1, before the upload even runs
```
With `fail_ci_if_error: true`, a flaked leg **fails** → that flag's coverage never uploads (Codecov shows stale) → and `notify-failure` fires spuriously. It's transient (sibling legs in the same run upload fine) and can hit any flag on any PR — observed failing the `notebook-migration-service` leg on an unrelated run.
**Fix:** run each upload as **attempt + one retry**. The first attempt is `continue-on-error`, so a transient flake doesn't fail the leg; the retry (same inputs, `fail_ci_if_error: true`, no `continue-on-error`) runs only when the first failed. A *persistent* failure still fails the leg → `notify-failure`; a transient CLI-download/GPG flake **self-heals** on the retry. CLI signature verification is kept intact (no `skip_validation`).
### Any related issues, documentation, discussions?
Reported on #6800. Follow-up to #6730 / #6824.
### How was this PR tested?
- `workflow_run` only activates from the copy on the default branch, so this can't run on its own PR. YAML validated; the retry logic is gated on `steps.<id>.outcome == 'failure'`, so it re-runs only after a failed first attempt and skips cleanly when the first attempt succeeded or was itself skipped (e.g. `amber-integration`, which has no coverage report).
- The `workflow_dispatch` (`run_id`) entry remains for manual post-merge validation.
### Was this PR authored or co-authored using generative AI tooling?
Yes.
Generated-by: Claude Code (Opus 4.8 [1M context])
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: retry Codecov upload to survive flaky CLI signature verification [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed pull request #6836: ci: retry Codecov upload to survive flaky CLI signature verification
URL: https://github.com/apache/texera/pull/6836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: retry Codecov upload to survive flaky CLI signature verification [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6836:
URL: https://github.com/apache/texera/pull/6836#issuecomment-5062980479
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6836?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 76.28%. Comparing base ([`dda9e83`](https://app.codecov.io/gh/apache/texera/commit/dda9e830f54e0fa74dcf0fd5d41a3c2e1a0c989c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7b98db1`](https://app.codecov.io/gh/apache/texera/commit/7b98db1c382f2e51f3994df9f52ef07ee8b67a18?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #6836 +/- ##
=========================================
Coverage 76.28% 76.28%
Complexity 3452 3452
=========================================
Files 1161 1161
Lines 45916 45916
Branches 5099 5099
=========================================
Hits 35025 35025
Misses 9327 9327
Partials 1564 1564
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/6836/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6836/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [dda9e83](https://app.codecov.io/gh/apache/texera/commit/dda9e830f54e0fa74dcf0fd5d41a3c2e1a0c989c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/6836/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.76% <ø> (ø)` | | Carriedforward from [dda9e83](https://app.codecov.io/gh/apache/texera/commit/dda9e830f54e0fa74dcf0fd5d41a3c2e1a0c989c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/6836/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.33% <ø> (ø)` | | Carriedforward from [dda9e83](https://app.codecov.io/gh/apache/texera/commit/dda9e830f54e0fa74dcf0fd5d41a3c2e1a0c989c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6836/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `20.49% <ø> (ø)` | | Carriedforward from [dda9e83](https://app.codecov.io/gh/apache/texera/commit/dda9e830f54e0fa74dcf0fd5d41a3c2e1a0c989c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/6836/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.66% <ø> (ø)` | | Carriedforward from [dda9e83](https://app.codecov.io/gh/apache/texera/commit/dda9e830f54e0fa74dcf0fd5d41a3c2e1a0c989c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/6836/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.21% <ø> (ø)` | | Carriedforward from [dda9e83](https://app.codecov.io/gh/apache/texera/commit/dda9e830f54e0fa74dcf0fd5d41a3c2e1a0c989c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/6836/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.72% <ø> (ø)` | | Carriedforward from [dda9e83](https://app.codecov.io/gh/apache/texera/commit/dda9e830f54e0fa74dcf0fd5d41a3c2e1a0c989c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/6836/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.94% <ø> (ø)` | | Carriedforward from [dda9e83](https://app.codecov.io/gh/apache/texera/commit/dda9e830f54e0fa74dcf0fd5d41a3c2e1a0c989c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/6836/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `92.15% <ø> (ø)` | | Carriedforward from [dda9e83](https://app.codecov.io/gh/apache/texera/commit/dda9e830f54e0fa74dcf0fd5d41a3c2e1a0c989c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6836/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [dda9e83](https://app.codecov.io/gh/apache/texera/commit/dda9e830f54e0fa74dcf0fd5d41a3c2e1a0c989c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6836?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: retry Codecov upload to survive flaky CLI signature verification [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6836:
URL: https://github.com/apache/texera/pull/6836#issuecomment-5062924915
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 5 better · 🔴 1 worse · ⚪ 9 noise (<±5%) · 0 without baseline
> Compared against main `dda9e83` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/30040714290)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🟢 | bs=10 sw=10 sl=64 | 361 | 0.22 | 28,707/35,789/35,789 us | 🟢 -7.5% / 🔴 +127.4% |
| 🔴 | bs=100 sw=10 sl=64 | 775 | 0.473 | 129,772/139,728/139,728 us | 🔴 +5.7% / 🔴 +31.3% |
| ⚪ | bs=1000 sw=10 sl=64 | 895 | 0.546 | 1,114,825/1,153,630/1,153,630 us | ⚪ within ±5% / 🔴 +14.5% |
<details><summary>Baseline details</summary>
Latest main `dda9e83` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 361 tuples/sec | 337 tuples/sec | 767.66 tuples/sec | +7.1% | -53.0% |
| bs=10 sw=10 sl=64 | MB/s | 0.22 MB/s | 0.206 MB/s | 0.469 MB/s | +6.8% | -53.0% |
| bs=10 sw=10 sl=64 | p50 | 28,707 us | 31,043 us | 12,623 us | -7.5% | +127.4% |
| bs=10 sw=10 sl=64 | p95 | 35,789 us | 38,626 us | 16,011 us | -7.3% | +123.5% |
| bs=10 sw=10 sl=64 | p99 | 35,789 us | 38,626 us | 18,856 us | -7.3% | +89.8% |
| bs=100 sw=10 sl=64 | throughput | 775 tuples/sec | 798 tuples/sec | 998.44 tuples/sec | -2.9% | -22.4% |
| bs=100 sw=10 sl=64 | MB/s | 0.473 MB/s | 0.487 MB/s | 0.609 MB/s | -2.9% | -22.4% |
| bs=100 sw=10 sl=64 | p50 | 129,772 us | 122,797 us | 100,463 us | +5.7% | +29.2% |
| bs=100 sw=10 sl=64 | p95 | 139,728 us | 145,927 us | 106,400 us | -4.2% | +31.3% |
| bs=100 sw=10 sl=64 | p99 | 139,728 us | 145,927 us | 117,712 us | -4.2% | +18.7% |
| bs=1000 sw=10 sl=64 | throughput | 895 tuples/sec | 911 tuples/sec | 1,034 tuples/sec | -1.8% | -13.5% |
| bs=1000 sw=10 sl=64 | MB/s | 0.546 MB/s | 0.556 MB/s | 0.631 MB/s | -1.8% | -13.5% |
| bs=1000 sw=10 sl=64 | p50 | 1,114,825 us | 1,093,967 us | 973,294 us | +1.9% | +14.5% |
| bs=1000 sw=10 sl=64 | p95 | 1,153,630 us | 1,161,395 us | 1,019,213 us | -0.7% | +13.2% |
| bs=1000 sw=10 sl=64 | p99 | 1,153,630 us | 1,161,395 us | 1,049,896 us | -0.7% | +9.9% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,554.15,200,128000,361,0.220,28706.73,35789.10,35789.10
1,100,10,64,20,2579.40,2000,1280000,775,0.473,129772.04,139727.86,139727.86
2,1000,10,64,20,22345.32,20000,12800000,895,0.546,1114824.68,1153629.81,1153629.81
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: retry Codecov upload to survive flaky CLI signature verification [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6836:
URL: https://github.com/apache/texera/pull/6836#issuecomment-5062849595
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: retry Codecov upload to survive flaky CLI signature verification [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #6836:
URL: https://github.com/apache/texera/pull/6836#issuecomment-5063030053
not correct fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org