You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2015/08/28 20:33:07 UTC
Review Request 37899: Implementing mapping objects to Lucene documents
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37899/
-----------------------------------------------------------
Review request for geode, Ashvin A and xiaojian zhou.
Repository: geode
Description
-------
I've added an implementation of the code that converts and object to a
document. As part of this, I renamed a couple of interfaces
ObjectToDocumentMapper -> LuceneSerializer
SingleIndexRepository -> IndexRepository
The LuceneSerializer is an interface I hope maybe we can allow users
to implement if they want so they can customize how their object gets
converted to a Document - for example for spatial indexing.
I've implemented the LuceneSerializer and added unit tests. I also
implemented IndexRepository and added a unit test for that as well.
Diffs
-----
gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListener.java 1eca80ab148b071c26197846838645c639a6d6e9
gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java PRE-CREATION
gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/ObjectToDocumentMapper.java 24612ca3b211b690d2ac0bffc2a809082cbd3dd8
gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/RepositoryManager.java a6879a9f039dee5c5240c072c21e8aac46325d62
gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepository.java f4cc4ef026403857efe2dcf891fe5376e350e0f2
gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepositoryImpl.java 944cf41ad3597fe6d9b9b81fde58bcd971fbd58d
gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/HeterogenousLuceneSerializer.java PRE-CREATION
gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/LuceneSerializer.java PRE-CREATION
gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxLuceneSerializer.java PRE-CREATION
gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionLuceneSerializer.java PRE-CREATION
gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/SerializerUtil.java PRE-CREATION
gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListenerJUnitTest.java ca80db1b308b4403639638923976cb0f8be23542
gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepositoryImplJUnitTest.java PRE-CREATION
gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/HeterogenousLuceneSerializerJUnitTest.java PRE-CREATION
gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxFieldMapperJUnitTest.java PRE-CREATION
gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionFieldMapperJUnitTest.java PRE-CREATION
gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/Type1.java PRE-CREATION
gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/Type2.java PRE-CREATION
Diff: https://reviews.apache.org/r/37899/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 37899: Implementing mapping objects to Lucene
documents
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37899/#review96937
-----------------------------------------------------------
Ship it!
Ship It!
- xiaojian zhou
On Aug. 28, 2015, 6:33 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37899/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2015, 6:33 p.m.)
>
>
> Review request for geode, Ashvin A and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> I've added an implementation of the code that converts and object to a
> document. As part of this, I renamed a couple of interfaces
> ObjectToDocumentMapper -> LuceneSerializer
> SingleIndexRepository -> IndexRepository
>
> The LuceneSerializer is an interface I hope maybe we can allow users
> to implement if they want so they can customize how their object gets
> converted to a Document - for example for spatial indexing.
>
> I've implemented the LuceneSerializer and added unit tests. I also
> implemented IndexRepository and added a unit test for that as well.
>
>
> Diffs
> -----
>
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListener.java 1eca80ab148b071c26197846838645c639a6d6e9
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java PRE-CREATION
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/ObjectToDocumentMapper.java 24612ca3b211b690d2ac0bffc2a809082cbd3dd8
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/RepositoryManager.java a6879a9f039dee5c5240c072c21e8aac46325d62
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepository.java f4cc4ef026403857efe2dcf891fe5376e350e0f2
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepositoryImpl.java 944cf41ad3597fe6d9b9b81fde58bcd971fbd58d
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/HeterogenousLuceneSerializer.java PRE-CREATION
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/LuceneSerializer.java PRE-CREATION
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxLuceneSerializer.java PRE-CREATION
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionLuceneSerializer.java PRE-CREATION
> gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/SerializerUtil.java PRE-CREATION
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListenerJUnitTest.java ca80db1b308b4403639638923976cb0f8be23542
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepositoryImplJUnitTest.java PRE-CREATION
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/HeterogenousLuceneSerializerJUnitTest.java PRE-CREATION
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/PdxFieldMapperJUnitTest.java PRE-CREATION
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionFieldMapperJUnitTest.java PRE-CREATION
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/Type1.java PRE-CREATION
> gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/Type2.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37899/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>