You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2013/11/10 20:16:48 UTC
Review Request 15393: Fix for bug CLOUDSTACK-5121
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15393/
-----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
Bugs: CLOUDSTACK-5121
https://issues.apache.org/jira/browse/CLOUDSTACK-5121
Repository: cloudstack-git
Description
-------
There were few test cases failing because of wrong way of object creation.
Fixed it.
Diffs
-----
tools/marvin/marvin/cloudstackConnection.py 2c027c3
tools/marvin/marvin/cloudstackTestClient.py 3e833c7
tools/marvin/marvin/integration/lib/utils.py 0fe3c26
tools/marvin/marvin/sandbox/demo/simulator/testcase/libs/utils.py f26d2c0
Diff: https://reviews.apache.org/r/15393/diff/
Testing
-------
Yes, Worked to create deploydatacenters and few test cases thereafter
Thanks,
Santhosh Edukulla
Re: Review Request 15393: Fix for bug CLOUDSTACK-5121
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15393/#review28637
-----------------------------------------------------------
Ship it!
- Prasanna Santhanam
On Nov. 10, 2013, 7:16 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15393/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2013, 7:16 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-5121
> https://issues.apache.org/jira/browse/CLOUDSTACK-5121
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There were few test cases failing because of wrong way of object creation.
> Fixed it.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackConnection.py 2c027c3
> tools/marvin/marvin/cloudstackTestClient.py 3e833c7
> tools/marvin/marvin/integration/lib/utils.py 0fe3c26
> tools/marvin/marvin/sandbox/demo/simulator/testcase/libs/utils.py f26d2c0
>
> Diff: https://reviews.apache.org/r/15393/diff/
>
>
> Testing
> -------
>
> Yes, Worked to create deploydatacenters and few test cases thereafter
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 15393: Fix for bug CLOUDSTACK-5121
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15393/#review28639
-----------------------------------------------------------
Commit e82fe016920d42afd3c648d370dfc5de61e03c48 in branch refs/heads/4.2 from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e82fe01 ]
CLOUDSTACK-5121: There was one wrong initialization of cloudstackConnection.
The bug mentioned is causing test cases to fail.
Signed-off-by: Santhosh Edukulla <Sa...@citrix.com>
Conflicts:
tools/marvin/marvin/cloudstackConnection.py
- ASF Subversion and Git Services
On Nov. 10, 2013, 7:16 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15393/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2013, 7:16 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-5121
> https://issues.apache.org/jira/browse/CLOUDSTACK-5121
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There were few test cases failing because of wrong way of object creation.
> Fixed it.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackConnection.py 2c027c3
> tools/marvin/marvin/cloudstackTestClient.py 3e833c7
> tools/marvin/marvin/integration/lib/utils.py 0fe3c26
> tools/marvin/marvin/sandbox/demo/simulator/testcase/libs/utils.py f26d2c0
>
> Diff: https://reviews.apache.org/r/15393/diff/
>
>
> Testing
> -------
>
> Yes, Worked to create deploydatacenters and few test cases thereafter
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 15393: Fix for bug CLOUDSTACK-5121
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15393/#review28636
-----------------------------------------------------------
Commit 175ead4ea96b72168aaa61b061b3345b1f29f5c2 in branch refs/heads/master from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=175ead4 ]
CLOUDSTACK-5121: There was one wrong initialization of cloudstackConnection.
The bug mentioned is causing test cases to fail.
Signed-off-by: Santhosh Edukulla <Sa...@citrix.com>
- ASF Subversion and Git Services
On Nov. 10, 2013, 7:16 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15393/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2013, 7:16 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-5121
> https://issues.apache.org/jira/browse/CLOUDSTACK-5121
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There were few test cases failing because of wrong way of object creation.
> Fixed it.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackConnection.py 2c027c3
> tools/marvin/marvin/cloudstackTestClient.py 3e833c7
> tools/marvin/marvin/integration/lib/utils.py 0fe3c26
> tools/marvin/marvin/sandbox/demo/simulator/testcase/libs/utils.py f26d2c0
>
> Diff: https://reviews.apache.org/r/15393/diff/
>
>
> Testing
> -------
>
> Yes, Worked to create deploydatacenters and few test cases thereafter
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 15393: Fix for bug CLOUDSTACK-5121
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15393/#review29366
-----------------------------------------------------------
Commit 980e66d501f525672827c207d8b0921f819e5fcd in branch refs/heads/4.3 from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=980e66d ]
CLOUDSTACK-5121: There was one wrong initialization of cloudstackConnection.
The bug mentioned is causing test cases to fail.
Signed-off-by: Girish Shilamkar <gi...@clogeny.com>
Conflicts:
tools/marvin/marvin/cloudstackConnection.py
Conflicts:
tools/marvin/marvin/cloudstackConnection.py
- ASF Subversion and Git Services
On Nov. 10, 2013, 7:16 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15393/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2013, 7:16 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-5121
> https://issues.apache.org/jira/browse/CLOUDSTACK-5121
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There were few test cases failing because of wrong way of object creation.
> Fixed it.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackConnection.py 2c027c3
> tools/marvin/marvin/cloudstackTestClient.py 3e833c7
> tools/marvin/marvin/integration/lib/utils.py 0fe3c26
> tools/marvin/marvin/sandbox/demo/simulator/testcase/libs/utils.py f26d2c0
>
> Diff: https://reviews.apache.org/r/15393/diff/
>
>
> Testing
> -------
>
> Yes, Worked to create deploydatacenters and few test cases thereafter
>
>
> Thanks,
>
> Santhosh Edukulla
>
>