You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/02/01 23:04:34 UTC
[GitHub] [accumulo] ctubbsii opened a new pull request #2453: Remove redundant native map loading
ctubbsii opened a new pull request #2453:
URL: https://github.com/apache/accumulo/pull/2453
Remove redundant call to NativeMapLoader.load() in NativeMap, which
isn't needed because the TabletServerResourceManager already loads it
when the tserver starts up. This static initializer caused problems with
test references to NativeMap, and tried to load the native map library
before the test had a chance to load it from the search path.
Instead, if NativeMap is attempted to be used without loading the native
library, it will just naturally throw an UnsatisfiedLinkError.
This fixes #2450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #2453: Remove redundant native map loading
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #2453:
URL: https://github.com/apache/accumulo/pull/2453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2453: Remove redundant native map loading
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #2453:
URL: https://github.com/apache/accumulo/pull/2453#issuecomment-1027399743
@milleruntime already mentioned that this was redundant in #2425, but I thought leaving it best preserved existing behavior. It turns out we don't really need to preserve existing behavior, because if somebody tries to use NativeMap without loading the library, it will just throw an UnsatisfiedLinkError, which is totally fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org