[GitHub] [hive] zratkai commented on a diff in pull request #4121: HIVE-26809: Upgrade ORC to 1.8.3

["zratkai (via GitHub)" <gi...@apache.org>]

zratkai commented on code in PR #4121:
URL: https://github.com/apache/hive/pull/4121#discussion_r1155725610


##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##########
@@ -298,11 +300,11 @@ public void seek(PositionProvider index) throws IOException {
       }
     }
 
-    @Override
+    @Override        
     public void nextVector(
-        ColumnVector previousVector, boolean[] isNull, int batchSize) throws IOException {
+        ColumnVector previousVector, boolean[] isNull, int batchSize, FilterContext filterContext, TypeReader.ReadPhase readPhase) throws IOException {

Review Comment:
   Reformatted to match the style.



##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##########
@@ -298,11 +300,11 @@ public void seek(PositionProvider index) throws IOException {
       }
     }
 
-    @Override
+    @Override        

Review Comment:
   Reformatted to match the style.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org