You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/02 10:57:02 UTC
[GitHub] [airflow] ashb opened a new pull request #19363: Fix message on "Mark as" confirmation page
ashb opened a new pull request #19363:
URL: https://github.com/apache/airflow/pull/19363
In an earlier refactor I created a macro called `message` which
"stomped" on the variable of the same name set in the view, meaning the
page shows `<Macro message>` instead of the string we meant to set.
This "fixes" it by using a less-likely-to-clash name for the macro (and
fixing the typo in `dismissible` parameter.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #19363: Fix message on "Mark as" confirmation page
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #19363:
URL: https://github.com/apache/airflow/pull/19363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #19363: Fix message on "Mark as" confirmation page
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #19363:
URL: https://github.com/apache/airflow/pull/19363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #19363: Fix message on "Mark as" confirmation page
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #19363:
URL: https://github.com/apache/airflow/pull/19363#discussion_r741097938
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -50,10 +50,10 @@
{% block messages %}
{% for m in dashboard_alerts %}
- {{ message(m.message, m.category) }}
+ {{ show_message(m.message, m.category) }}
Review comment:
Seems there's a missing import of `show_messge`, line 22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #19363: Fix message on "Mark as" confirmation page
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #19363:
URL: https://github.com/apache/airflow/pull/19363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19363: Fix message on "Mark as" confirmation page
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19363:
URL: https://github.com/apache/airflow/pull/19363#issuecomment-957933497
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #19363: Fix message on "Mark as" confirmation page
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #19363:
URL: https://github.com/apache/airflow/pull/19363#discussion_r740995053
##########
File path: airflow/www/templates/airflow/main.html
##########
@@ -67,7 +67,7 @@
{% endcall %}
{% endif %}
{% if triggerer_job is defined and (not triggerer_job or not triggerer_job.is_alive()) %}
- {% call message(category='warning', dismissable=false) %}
+ {% call show_message(category='warning', dismissabie=false) %}
Review comment:
```suggestion
{% call show_message(category='warning', dismissible=false) %}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19363: Fix message on "Mark as" confirmation page
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19363:
URL: https://github.com/apache/airflow/pull/19363#issuecomment-957933497
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #19363: Fix message on "Mark as" confirmation page
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #19363:
URL: https://github.com/apache/airflow/pull/19363#discussion_r740995053
##########
File path: airflow/www/templates/airflow/main.html
##########
@@ -67,7 +67,7 @@
{% endcall %}
{% endif %}
{% if triggerer_job is defined and (not triggerer_job or not triggerer_job.is_alive()) %}
- {% call message(category='warning', dismissable=false) %}
+ {% call show_message(category='warning', dismissabie=false) %}
Review comment:
```suggestion
{% call show_message(category='warning', dismissible=false) %}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #19363: Fix message on "Mark as" confirmation page
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #19363:
URL: https://github.com/apache/airflow/pull/19363#discussion_r740995053
##########
File path: airflow/www/templates/airflow/main.html
##########
@@ -67,7 +67,7 @@
{% endcall %}
{% endif %}
{% if triggerer_job is defined and (not triggerer_job or not triggerer_job.is_alive()) %}
- {% call message(category='warning', dismissable=false) %}
+ {% call show_message(category='warning', dismissabie=false) %}
Review comment:
```suggestion
{% call show_message(category='warning', dismissible=false) %}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19363: Fix message on "Mark as" confirmation page
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19363:
URL: https://github.com/apache/airflow/pull/19363#issuecomment-957933497
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #19363: Fix message on "Mark as" confirmation page
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #19363:
URL: https://github.com/apache/airflow/pull/19363#discussion_r741097938
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -50,10 +50,10 @@
{% block messages %}
{% for m in dashboard_alerts %}
- {{ message(m.message, m.category) }}
+ {{ show_message(m.message, m.category) }}
Review comment:
Seems there's a missing import of `show_messge`, line 22
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -50,10 +50,10 @@
{% block messages %}
{% for m in dashboard_alerts %}
- {{ message(m.message, m.category) }}
+ {{ show_message(m.message, m.category) }}
Review comment:
Seems there's a missing import of `show_message`, line 22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #19363: Fix message on "Mark as" confirmation page
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #19363:
URL: https://github.com/apache/airflow/pull/19363#discussion_r741097938
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -50,10 +50,10 @@
{% block messages %}
{% for m in dashboard_alerts %}
- {{ message(m.message, m.category) }}
+ {{ show_message(m.message, m.category) }}
Review comment:
Seems there's a missing import of `show_message`, line 22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #19363: Fix message on "Mark as" confirmation page
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #19363:
URL: https://github.com/apache/airflow/pull/19363#discussion_r741097938
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -50,10 +50,10 @@
{% block messages %}
{% for m in dashboard_alerts %}
- {{ message(m.message, m.category) }}
+ {{ show_message(m.message, m.category) }}
Review comment:
Seems there's a missing import of `show_messge`, line 22
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -50,10 +50,10 @@
{% block messages %}
{% for m in dashboard_alerts %}
- {{ message(m.message, m.category) }}
+ {{ show_message(m.message, m.category) }}
Review comment:
Seems there's a missing import of `show_message`, line 22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org