You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Prasad Chakka (JIRA)" <ji...@apache.org> on 2009/03/30 05:22:50 UTC
[jira] Created: (HIVE-378) comments in between hive queries throw
up errors
comments in between hive queries throw up errors
------------------------------------------------
Key: HIVE-378
URL: https://issues.apache.org/jira/browse/HIVE-378
Project: Hadoop Hive
Issue Type: Bug
Components: Clients
Affects Versions: 0.4.0
Reporter: Prasad Chakka
Assignee: Prasad Chakka
Priority: Minor
Fix For: 0.4.0
comments (lines starting with '\w*--') throw up errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-378) comments in between hive queries throw
up errors
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693683#action_12693683 ]
Raghotham Murthy commented on HIVE-378:
---------------------------------------
It might be better to remove comments in the parser, since its easier to deal with quoted strings containing '--'. Your change will convert a comment-less query like the following:
select '--test--', * from src
into an invalid query: select '
> comments in between hive queries throw up errors
> ------------------------------------------------
>
> Key: HIVE-378
> URL: https://issues.apache.org/jira/browse/HIVE-378
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Clients
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: hive-378.patch
>
>
> comments (lines starting with '\w*--') throw up errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HIVE-378) comments in between hive
queries throw up errors
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693818#action_12693818 ]
Prasad Chakka edited comment on HIVE-378 at 3/30/09 9:46 AM:
-------------------------------------------------------------
Only those lines that end in a new line will be removed. That should be enough since the probability of a string literal spanning multiple lines is low.
Correct way would be to make all non-query commands (such as dfs, !, set etc) go through parser.
was (Author: prasadc):
you are right but that wouldn't solve the problem either since commands like 'set', 'dfs' doesn't go through parser. May be that is the problem and all commands should go through parser.
> comments in between hive queries throw up errors
> ------------------------------------------------
>
> Key: HIVE-378
> URL: https://issues.apache.org/jira/browse/HIVE-378
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Clients
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Priority: Minor
> Attachments: hive-378.patch
>
>
> comments (lines starting with '\w*--') throw up errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-378) comments in between hive queries throw
up errors
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka updated HIVE-378:
-------------------------------
Status: Patch Available (was: Open)
> comments in between hive queries throw up errors
> ------------------------------------------------
>
> Key: HIVE-378
> URL: https://issues.apache.org/jira/browse/HIVE-378
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Clients
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: hive-378.patch
>
>
> comments (lines starting with '\w*--') throw up errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-378) comments in between hive queries throw
up errors
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka updated HIVE-378:
-------------------------------
Fix Version/s: (was: 0.4.0)
Assignee: (was: Prasad Chakka)
Status: Open (was: Patch Available)
you are right but that wouldn't solve the problem either since commands like 'set', 'dfs' doesn't go through parser. May be that is the problem and all commands should go through parser.
> comments in between hive queries throw up errors
> ------------------------------------------------
>
> Key: HIVE-378
> URL: https://issues.apache.org/jira/browse/HIVE-378
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Clients
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Priority: Minor
> Attachments: hive-378.patch
>
>
> comments (lines starting with '\w*--') throw up errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-378) comments in between hive queries throw
up errors
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Chakka updated HIVE-378:
-------------------------------
Attachment: hive-378.patch
want to add comments for unit tests in my HIVE-278 patch so made this quick patch.
> comments in between hive queries throw up errors
> ------------------------------------------------
>
> Key: HIVE-378
> URL: https://issues.apache.org/jira/browse/HIVE-378
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Clients
> Affects Versions: 0.4.0
> Reporter: Prasad Chakka
> Assignee: Prasad Chakka
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: hive-378.patch
>
>
> comments (lines starting with '\w*--') throw up errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.