[GitHub] [solr] madrob commented on a change in pull request #200: LUCENE-8682: remove deprecated WordDelimiterFilter[Factory] classes

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #200:
URL: https://github.com/apache/solr/pull/200#discussion_r665588229



##########
File path: solr/core/src/test/org/apache/solr/analysis/TestWordDelimiterGraphFilterFactory.java
##########
@@ -207,16 +189,16 @@ public void testCustomTypes() throws Exception {
     args.put("splitOnCaseChange", "1");
     
     /* default behavior */
-    WordDelimiterFilterFactory factoryDefault = new WordDelimiterFilterFactory(args);
+    WordDelimiterGraphFilterFactory factoryDefault = new WordDelimiterGraphFilterFactory(args);
     factoryDefault.inform(loader);
     
     TokenStream ts = factoryDefault.create(whitespaceMockTokenizer(testText));
     BaseTokenStreamTestCase.assertTokenStreamContents(ts, 
-        new String[] { "I", "borrowed", "5", "540000", "400", "00", "at", "25", "interest", "interestrate", "rate" });
+        new String[] { "I", "borrowed", "540000", "5", "400", "00", "at", "25", "interestrate", "interest", "rate" });

Review comment:
       Slightly concerning here that we are dependent on order from something that I presume is not order-defined.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org