You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Martin Kraemer <Ma...@mch.sni.de> on 1997/10/20 17:35:50 UTC
[PATCH] Global variables should be set in MainServer, not
In http_core.c, quite a few directives modify global (i.e., main server)
variables without checking for <VirtualHost> context first. That gives the
user the impression that these directives were accepted and applicable to
VirtualHosts (who reads the man pages anyway ;-).
These cases are blocked with the appended patch: like some of the other
directives, these are now refused with "... directive not allowed for
<VirtualHost>".
Two more bugs are fixed with this patch too:
1) LogLevel didn't yell about invalid level keywords
2) </Limit> was configured to accept RAW_ARGS, should be NO_ARGS
Martin
--
| S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
| ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
| N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
Re: [PATCH] Global variables should be set in MainServer, not
Posted by Dean Gaudet <dg...@arctic.org>.
+1
On Mon, 20 Oct 1997, Martin Kraemer wrote:
> In http_core.c, quite a few directives modify global (i.e., main server)
> variables without checking for <VirtualHost> context first. That gives the
> user the impression that these directives were accepted and applicable to
> VirtualHosts (who reads the man pages anyway ;-).
>
> These cases are blocked with the appended patch: like some of the other
> directives, these are now refused with "... directive not allowed for
> <VirtualHost>".
>
> Two more bugs are fixed with this patch too:
> 1) LogLevel didn't yell about invalid level keywords
> 2) </Limit> was configured to accept RAW_ARGS, should be NO_ARGS
>
> Martin
> --
> | S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
> | ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
> | N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
> ~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
>