You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/26 07:24:07 UTC

[GitHub] [superset] villebro edited a comment on pull request #12736: fix: Remove double tooltip from metric label

villebro edited a comment on pull request #12736:
URL: https://github.com/apache/superset/pull/12736#issuecomment-767348938


   This looks great! A few observations:
   - When using Tab to commit a value to the IN filter, the focus shifts to the Save button: 
   ![sf](https://user-images.githubusercontent.com/33317356/105811756-c2643b00-5fb5-11eb-8f26-c3f86d92c37a.gif)
   
   - For saved metrics this seems to work as expected, but for simple and custom metrics the tooltip doesn't appear: 
   ![simple](https://user-images.githubusercontent.com/33317356/105811217-effcb480-5fb4-11eb-9986-0903b46f1123.gif)
   
   - Now that we only display a single tooltip, I wonder if it would be easier on the eyes to have both tooltips on the top?
   ![tooltip](https://user-images.githubusercontent.com/33317356/105811405-45d15c80-5fb5-11eb-9e6d-d81c07e2a1f5.gif)
   vs
   ![top](https://user-images.githubusercontent.com/33317356/105813179-238d0e00-5fb8-11eb-86e2-78244b30fd90.gif)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org