You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/26 08:03:36 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
AngersZhuuuu opened a new pull request #31341:
URL: https://github.com/apache/spark/pull/31341
### What changes were proposed in this pull request?
Passing around the output attributes should have more benefits like keeping the expr ID unchanged to avoid bugs when we apply more operators above the command output dataframe.
This PR keep SHOW PARTITIONS command's output attribute exprId unchanged.
### Why are the changes needed?
Keep SHOW PARTITIONS command's output attribute exprid unchanged.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Added UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768832807
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134578/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768037242
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39117/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768774636
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39164/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768021257
**[Test build #134532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134532/testReport)** for PR 31341 at commit [`9975150`](https://github.com/apache/spark/commit/9975150961eb6293c27a0c26f8cf4a69952ae343).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-767539379
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134491/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu edited a comment on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu edited a comment on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-774613080
@cloud-fan Should we add
```
object ShowPartitions {
val OUTPUT = xxx
}
```
to keep consistence?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768804331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-767480666
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39077/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768021257
**[Test build #134532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134532/testReport)** for PR 31341 at commit [`9975150`](https://github.com/apache/spark/commit/9975150961eb6293c27a0c26f8cf4a69952ae343).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-767389435
**[Test build #134491 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134491/testReport)** for PR 31341 at commit [`a5a37e0`](https://github.com/apache/spark/commit/a5a37e03d471814b35725bcc78cc51b805bc638a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-767522706
**[Test build #134491 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134491/testReport)** for PR 31341 at commit [`a5a37e0`](https://github.com/apache/spark/commit/a5a37e03d471814b35725bcc78cc51b805bc638a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-767373228
FYI @HyukjinKwon @cloud-fan @beliefer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768832807
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134578/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-767465500
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39077/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768155605
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134532/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768155605
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134532/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-767389435
**[Test build #134491 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134491/testReport)** for PR 31341 at commit [`a5a37e0`](https://github.com/apache/spark/commit/a5a37e03d471814b35725bcc78cc51b805bc638a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768051051
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39117/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768128675
**[Test build #134532 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134532/testReport)** for PR 31341 at commit [`9975150`](https://github.com/apache/spark/commit/9975150961eb6293c27a0c26f8cf4a69952ae343).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-774876014
@AngersZhuuuu yea I think so
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31341:
URL: https://github.com/apache/spark/pull/31341
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-767415059
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39077/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #31341:
URL: https://github.com/apache/spark/pull/31341#discussion_r565018727
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowPartitionsSuite.scala
##########
@@ -126,4 +127,22 @@ class ShowPartitionsSuite extends ShowPartitionsSuiteBase with CommandSuiteBase
checkAnswer(spark.table(t), Row(0, null) :: Row(1, null) :: Nil)
}
}
+
+ test("SPARK-34238 Unify output of SHOW PARTITIONS and pass output attributes properly") {
Review comment:
> Hm how does this test validate the change?
Hmmm, that's a problem... since it changed from ShowPartitions to ShowPartitionsCommand in analyzer level...
We can validate this in https://issues.apache.org/jira/browse/SPARK-34238
remove this UT first. Hmmm do you have any suggestion to validate this in current PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-767539379
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134491/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-774876516
> @AngersZhuuuu yea I think so
Yea， will raise follow up pr soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768770081
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39164/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768771625
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39164/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #31341:
URL: https://github.com/apache/spark/pull/31341#discussion_r565776888
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -972,10 +972,9 @@ case class ShowColumnsCommand(
*/
case class ShowPartitionsCommand(
tableName: TableIdentifier,
+ attributes: Seq[Attribute],
Review comment:
> why not just name this parameter `output`?
Never wrote like this before, lookup the code, some places write like that. Update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768754138
**[Test build #134578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134578/testReport)** for PR 31341 at commit [`fd4afee`](https://github.com/apache/spark/commit/fd4afeef8e7c1212c16f76358333fe2bf8d9f19b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31341:
URL: https://github.com/apache/spark/pull/31341#discussion_r565382661
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -972,10 +972,9 @@ case class ShowColumnsCommand(
*/
case class ShowPartitionsCommand(
tableName: TableIdentifier,
+ attributes: Seq[Attribute],
Review comment:
why not just name this parameter `output`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768774636
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39164/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768829233
**[Test build #134578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134578/testReport)** for PR 31341 at commit [`fd4afee`](https://github.com/apache/spark/commit/fd4afeef8e7c1212c16f76358333fe2bf8d9f19b).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768754138
**[Test build #134578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134578/testReport)** for PR 31341 at commit [`fd4afee`](https://github.com/apache/spark/commit/fd4afeef8e7c1212c16f76358333fe2bf8d9f19b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768065181
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39117/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-774613080
@cloud-fan Should we add
```
object ShowColumns {
val OUTPUT = xxx
}
```
to keep consistence?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31341:
URL: https://github.com/apache/spark/pull/31341#discussion_r564525662
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowPartitionsSuite.scala
##########
@@ -126,4 +127,22 @@ class ShowPartitionsSuite extends ShowPartitionsSuiteBase with CommandSuiteBase
checkAnswer(spark.table(t), Row(0, null) :: Row(1, null) :: Nil)
}
}
+
+ test("SPARK-34238 Unify output of SHOW PARTITIONS and pass output attributes properly") {
Review comment:
Hm how does this test validate the change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-768065181
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39117/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31341:
URL: https://github.com/apache/spark/pull/31341#issuecomment-767480666
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39077/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org