[GitHub] [libcloud] Kami edited a comment on issue #1536: Inconsistency in specifying TTL in DNS records between example and tests

[GitBox <gi...@apache.org>]

Kami edited a comment on issue #1536:
URL: https://github.com/apache/libcloud/issues/1536#issuecomment-752412165


   Thanks for reporting this.
   
   I believe ``extra["ttl"]`` was there first, but since specifying "random" attributes in ``extra`` dictionary is really a bad and unfriendly API, we decided to "promote" that attribute directly as a top-level ``Record.ttl`` object attribute a while back.
   
   The idea was to eventually remove ``extra["ttl"]`` support, but we haven't done that yet since it is a breaking changes.
   
   So in short - yes, I totally agree with you, there should only be one way and that should be ``Record.ttl`` attribute. Since removing support for ``extra["ttl"]`` is a breaking change, it involves those changes:
   
   1. Need to update all DNS drivers and code examples to ensure they correctly utilize ``record.ttl`` attribute
   2. Explicitly call out this breaking change in CHANGES.rst and docs/upgrade_notes.rst file
   3. Release that change with a major release since it's a breaking change
   4. Ideally also update ``extra["ttl"]`` to emit a deprecation warning for at least one release so users are wanted and have time to migrate


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org