You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/12/06 20:27:30 UTC
Review Request 64391: Fixed incorrect testing of existence of
variables.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64391/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
A change was made in a response to a Javascript linter, but
the corresponding change was incorrect:
https://github.com/apache/mesos/commit/af8404e7bf49201d7f3a0a563f43d767539558f0#diff-c4d2d75ab288353e2104377479e53a00L88
Specifically:
```
- page_size || $.error('Expecting page_size to be defined');
- truncate_length || $.error('Expecting truncate_length to be defined');
+ if (page_size) {
+ $.error('Expecting page_size to be defined')
+ }
+
+ if (truncate_length) {
+ $.error('Expecting truncate_length to be defined')
+ }
```
Diffs
-----
src/webui/master/static/js/jquery.pailer.js 93ff04bac328d72a45317b2f15ccbc5e45c161d4
Diff: https://reviews.apache.org/r/64391/diff/1/
Testing
-------
Thanks,
Michael Park
Re: Review Request 64391: Fixed incorrect testing of existence of
variables.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64391/#review193042
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Dec. 6, 2017, 8:27 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64391/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2017, 8:27 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The following was committed in response to a Javascript linter,
> but the corresponding change was incorrect.
> https://github.com/apache/mesos/commit/af8404e
>
> Specifically:
> ```
> - page_size || $.error('Expecting page_size to be defined');
> - truncate_length || $.error('Expecting truncate_length to be defined');
> + if (page_size) {
> + $.error('Expecting page_size to be defined')
> + }
> +
> + if (truncate_length) {
> + $.error('Expecting truncate_length to be defined')
> + }
> ```
>
>
> Diffs
> -----
>
> src/webui/master/static/js/jquery.pailer.js 93ff04bac328d72a45317b2f15ccbc5e45c161d4
>
>
> Diff: https://reviews.apache.org/r/64391/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>