You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by ja...@gmail.com on 2007/06/06 20:39:14 UTC

Re: svn commit: r544915 - in/geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples:pom.xml src/main/webapp/WEB-INF/jsp/debug-taglib.tldsrc/main/webapp/WEB-INF/jsp/example-taglib.tld src/main/webapp/WEB-INF/lib/

What is broken?  As I have said before the build worked fine for me. Please explain in more detail why these changes are required. 

--jason


-----Original Message-----
From: dwoods@apache.org

Date: Wed, 06 Jun 2007 18:38:47 
To:scm@geronimo.apache.org
Subject: svn commit: r544915 - in
 /geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples:
 pom.xml src/main/webapp/WEB-INF/jsp/debug-taglib.tld
 src/main/webapp/WEB-INF/jsp/example-taglib.tld src/main/webapp/WEB-INF/lib/


Author: dwoods
Date: Wed Jun  6 11:38:46 2007
New Revision: 544915

URL: http://svn.apache.org/viewvc?view=rev&rev=544915
Log:
GERONIMO-3215 Correct deployment errors with jsp-examples sample.  Removed jspc-maven-plugin usage as it breaks the sample and isn't worth the time to fix it....

Removed:
    geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/lib/
Modified:
    geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/pom.xml
    geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld
    geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld

Modified: geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/pom.xml
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/pom.xml?view=diff&rev=544915&r1=544914&r2=544915
==============================================================================
--- geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/pom.xml (original)
+++ geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/pom.xml Wed Jun  6 11:38:46 2007
@@ -58,13 +58,11 @@
     <build>
         <plugins>
             <plugin>
-                <groupId>org.codehaus.mojo.jspc</groupId>
-                <artifactId>jspc-maven-plugin</artifactId>
-            </plugin>
-            
-            <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-war-plugin</artifactId>
+                <configuration>
+                    <webXml>${pom.basedir}/src/main/webapp/WEB-INF/web.xml</webXml>
+                </configuration>
             </plugin>
         </plugins>
     </build>

Modified: geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld?view=diff&rev=544915&r1=544914&r2=544915
==============================================================================
--- geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld (original)
+++ geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld Wed Jun  6 11:38:46 2007
@@ -40,7 +40,7 @@
   <tag>
     <name>log</name>
     <tag-class>examples.LogTag</tag-class>
-    <body-content>TAGDEPENDENT</body-content>
+    <body-content>tagdependent</body-content>
     <description>
 	Perform a server side action; Log the message.
     </description>

Modified: geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld?view=diff&rev=544915&r1=544914&r2=544915
==============================================================================
--- geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld (original)
+++ geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld Wed Jun  6 11:38:46 2007
@@ -70,7 +70,7 @@
   <tag>
     <name>log</name>
     <tag-class>examples.LogTag</tag-class>
-    <body-content>TAGDEPENDENT</body-content>
+    <body-content>tagdependent</body-content>
     <description>
 	Perform a server side action; Log the message.
     </description>



Re: svn commit: r544915 - in/geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples:pom.xml src/main/webapp/WEB-INF/jsp/debug-taglib.tldsrc/main/webapp/WEB-INF/jsp/example-taglib.tld src/main/webapp/WEB-INF/lib/

Posted by Song Scorpio <sc...@gmail.com>.
1. Update 2 tlds to correct deployment error. This is to fix:
10:51:02,776 INFO  [DirectoryHotDeployer] Deploying
jsp-examples-2.0-SNAPSHOT.war
10:51:11,588 WARN  [JspModuleBuilderExtension] Invalid transformed taglib
org.apache.xmlbeans.XmlException: Invalid deployment descriptor: errors:

jsp-examples-2.0.war\WEB-INF\jsp\debug-taglib.tld:43:5: error:
cvc-enumeration-valid: string value 'TAGDEPENDENT' is not a valid
enumeration value for body-contentType in namespace
http://java.sun.com/xml/ns/javaee

10:51:12,279 WARN  [JspModuleBuilderExtension] Invalid transformed taglib
org.apache.xmlbeans.XmlException: Invalid deployment descriptor: errors:

jsp-examples-2.0.war\WEB-INF\jsp\example-taglib.tld:73:5: error:
cvc-enumeration-valid: string value 'TAGDEPENDENT' is not a valid
enumeration value for body-contentType in namespace
http://java.sun.com/xml/ns/javaee

2. Delete duplicate jstl.jar and standard.jar from WEB-INF/lib. This is to
fix:
jsp-examples-2.0.war\WEB-INF\lib\standard.jar!\META-INF\permittedTaglibs.tld:12:3:error:
cvc-complex-type.2.4a: Expected element 'short-name@
http://java.sun.com/xml/ns/javaee' instead of 'jsp-version@
http://java.sun.com/xml/ns/javaee' here in element taglib@
http://java.sun.com/xml/ns/javaee

jsp-examples-2.0.war\WEB-INF\lib\standard.jar!\META-INF\permittedTaglibs.tld:15:3:error:
cvc-complex-type.2.4a: Expected elements 'validator@
http://java.sun.com/xml/ns/javaee listener@http://java.sun.com/xml/ns/javaee
tag@http://java.sun.com/xml/ns/javaee tag-file@
http://java.sun.com/xml/ns/javaee function@http://java.sun.com/xml/ns/javaee
taglib-extension@http://java.sun.com/xml/ns/javaee' instead of 'display-name
@http://java.sun.com/xml/ns/javaee' here in element taglib@
http://java.sun.com/xml/ns/javaee
......
jsp-examples-2.0.war\WEB-INF\lib\standard.jar!\META-INF\scriptfree.tld:12:3:error:
cvc-complex-type.2.4a: Expected element 'short-name@
http://java.sun.com/xml/ns/javaee' instead of 'jsp-version@
http://java.sun.com/xml/ns/javaee' here in element taglib@
http://java.sun.com/xml/ns/javaee

jsp-examples-2.0.war\WEB-INF\lib\standard.jar!\META-INF\scriptfree.tld:23:7:error:
cvc-complex-type.2.4b: Element not allowed: description@
http://java.sun.com/xml/ns/javaee in element init-param@
http://java.sun.com/xml/ns/javaee
......

3. Update pom.xml to disable jspc since it will generate wrong web.xml. This
is to fix:
Following auto generated fragment:
-----------------------------------------
<!--
Automatically created by Apache Jakarta Tomcat JspC.
Place this fragment in the web.xml before all icon, display-name,
description, distributable, and context-param elements.
-->
    <servlet-mapping>
        <servlet-name>jsp.jsp2.simpletag.book_jsp</servlet-name>
        <url-pattern>/jsp2/simpletag/book.jsp</url-pattern>
    </servlet-mapping>

    <servlet-mapping>
        <servlet-name>jsp.jsp2.simpletag.hello_jsp</servlet-name>
        <url-pattern>/jsp2/simpletag/hello.jsp</url-pattern>
    </servlet-mapping>

    <servlet-mapping>
        <servlet-name>jsp.jsp2.simpletag.repeat_jsp</servlet-name>
        <url-pattern>/jsp2/simpletag/repeat.jsp</url-pattern>
    </servlet-mapping>
----------------------------------------
Will cause below error when accessing JSPs contain taglib:
15:43:24,600 ERROR [hello_jsp]] Servlet.service() for servlet
jsp.jsp2.simpletag.hello_jsp threw exception
javax.servlet.ServletException: org.apache.jasper.runtime.AnnotationHelper
    at org.apache.jasper.runtime.PageContextImpl.doHandlePageException(
PageContextImpl.java:855)
    at org.apache.jasper.runtime.PageContextImpl.handlePageException(
PageContextImpl.java:784)
    at jsp.jsp2.simpletag.hello_jsp._jspService(hello_jsp.java:63)
    at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
ApplicationFilterChain.java:290)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(
ApplicationFilterChain.java:206)
    at org.apache.catalina.core.StandardWrapperValve.invoke(
StandardWrapperValve.java:231)
    at org.apache.catalina.core.StandardContextValve.invoke(
StandardContextValve.java:175)
    at org.apache.geronimo.tomcat.valve.DefaultSubjectValve.invoke(
DefaultSubjectValve.java:51)
    at org.apache.catalina.authenticator.AuthenticatorBase.invoke(
AuthenticatorBase.java:433)
    at
org.apache.geronimo.tomcat.GeronimoStandardContext$SystemMethodValve.invoke(
GeronimoStandardContext.java:358)
    at org.apache.geronimo.tomcat.valve.GeronimoBeforeAfterValve.invoke(
GeronimoBeforeAfterValve.java:47)
    at org.apache.catalina.core.StandardHostValve.invoke(
StandardHostValve.java:128)
    at org.apache.catalina.valves.ErrorReportValve.invoke(
ErrorReportValve.java:104)
    at org.apache.catalina.core.StandardEngineValve.invoke(
StandardEngineValve.java:109)
    at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java
:543)
    at org.apache.catalina.connector.CoyoteAdapter.service(
CoyoteAdapter.java:238)
    at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java
:844)
    at
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(
Http11Protocol.java:634)
    at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java
:445)
    at java.lang.Thread.run(Thread.java:803)

2007/6/7, Jason Dillon <ja...@planet57.com>:
>
> What exactly was corrupted in the web.xml?
>
> --jason
>
>
> On Jun 6, 2007, at 1:29 PM, Donald Woods wrote:
>
> > When the sample is deployed as a WAR file (and not installed as a
> > CAR/Plugin) the sample JSP apps fail, due to a corrupted web.xml....
> > Sorry, but I don't have the runtime exceptions around anymore to post.
> >
> > -Donald
> >
> > jason.dillon@gmail.com wrote:
> >> What is broken?  As I have said before the build worked fine for
> >> me. Please explain in more detail why these changes are required.
> >> --jason
> >> -----Original Message-----
> >> From: dwoods@apache.org
> >> Date: Wed, 06 Jun 2007 18:38:47 To:scm@geronimo.apache.org
> >> Subject: svn commit: r544915 - in
> >>  /geronimo/server/trunk/applications/geronimo-examples/geronimo-
> >> jsp-examples:
> >>  pom.xml src/main/webapp/WEB-INF/jsp/debug-taglib.tld
> >>  src/main/webapp/WEB-INF/jsp/example-taglib.tld src/main/webapp/
> >> WEB-INF/lib/
> >> Author: dwoods
> >> Date: Wed Jun  6 11:38:46 2007
> >> New Revision: 544915
> >> URL: http://svn.apache.org/viewvc?view=rev&rev=544915
> >> Log:
> >> GERONIMO-3215 Correct deployment errors with jsp-examples sample.
> >> Removed jspc-maven-plugin usage as it breaks the sample and isn't
> >> worth the time to fix it....
> >> Removed:
> >>     geronimo/server/trunk/applications/geronimo-examples/geronimo-
> >> jsp-examples/src/main/webapp/WEB-INF/lib/
> >> Modified:
> >>     geronimo/server/trunk/applications/geronimo-examples/geronimo-
> >> jsp-examples/pom.xml
> >>     geronimo/server/trunk/applications/geronimo-examples/geronimo-
> >> jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld
> >>     geronimo/server/trunk/applications/geronimo-examples/geronimo-
> >> jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld
> >> Modified: geronimo/server/trunk/applications/geronimo-examples/
> >> geronimo-jsp-examples/pom.xml
> >> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
> >> applications/geronimo-examples/geronimo-jsp-examples/pom.xml?
> >> view=diff&rev=544915&r1=544914&r2=544915
> >> =====================================================================
> >> =========
> >> --- geronimo/server/trunk/applications/geronimo-examples/geronimo-
> >> jsp-examples/pom.xml (original)
> >> +++ geronimo/server/trunk/applications/geronimo-examples/geronimo-
> >> jsp-examples/pom.xml Wed Jun  6 11:38:46 2007
> >> @@ -58,13 +58,11 @@
> >>      <build>
> >>          <plugins>
> >>              <plugin>
> >> -                <groupId>org.codehaus.mojo.jspc</groupId>
> >> -                <artifactId>jspc-maven-plugin</artifactId>
> >> -            </plugin>
> >> -            -            <plugin>
> >>                  <groupId>org.apache.maven.plugins</groupId>
> >>                  <artifactId>maven-war-plugin</artifactId>
> >> +                <configuration>
> >> +                    <webXml>${pom.basedir}/src/main/webapp/WEB-
> >> INF/web.xml</webXml>
> >> +                </configuration>
> >>              </plugin>
> >>          </plugins>
> >>      </build>
> >> Modified: geronimo/server/trunk/applications/geronimo-examples/
> >> geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld
> >> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
> >> applications/geronimo-examples/geronimo-jsp-examples/src/main/
> >> webapp/WEB-INF/jsp/debug-taglib.tld?
> >> view=diff&rev=544915&r1=544914&r2=544915
> >> =====================================================================
> >> =========
> >> --- geronimo/server/trunk/applications/geronimo-examples/geronimo-
> >> jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld (original)
> >> +++ geronimo/server/trunk/applications/geronimo-examples/geronimo-
> >> jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld Wed Jun
> >> 6 11:38:46 2007
> >> @@ -40,7 +40,7 @@
> >>    <tag>
> >>      <name>log</name>
> >>      <tag-class>examples.LogTag</tag-class>
> >> -    <body-content>TAGDEPENDENT</body-content>
> >> +    <body-content>tagdependent</body-content>
> >>      <description>
> >>      Perform a server side action; Log the message.
> >>      </description>
> >> Modified: geronimo/server/trunk/applications/geronimo-examples/
> >> geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld
> >> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/
> >> applications/geronimo-examples/geronimo-jsp-examples/src/main/
> >> webapp/WEB-INF/jsp/example-taglib.tld?
> >> view=diff&rev=544915&r1=544914&r2=544915
> >> =====================================================================
> >> =========
> >> --- geronimo/server/trunk/applications/geronimo-examples/geronimo-
> >> jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld
> >> (original)
> >> +++ geronimo/server/trunk/applications/geronimo-examples/geronimo-
> >> jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld Wed
> >> Jun  6 11:38:46 2007
> >> @@ -70,7 +70,7 @@
> >>    <tag>
> >>      <name>log</name>
> >>      <tag-class>examples.LogTag</tag-class>
> >> -    <body-content>TAGDEPENDENT</body-content>
> >> +    <body-content>tagdependent</body-content>
> >>      <description>
> >>      Perform a server side action; Log the message.
> >>      </description>
>
>

Re: svn commit: r544915 - in/geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples:pom.xml src/main/webapp/WEB-INF/jsp/debug-taglib.tldsrc/main/webapp/WEB-INF/jsp/example-taglib.tld src/main/webapp/WEB-INF/lib/

Posted by Jason Dillon <ja...@planet57.com>.
What exactly was corrupted in the web.xml?

--jason


On Jun 6, 2007, at 1:29 PM, Donald Woods wrote:

> When the sample is deployed as a WAR file (and not installed as a  
> CAR/Plugin) the sample JSP apps fail, due to a corrupted web.xml....
> Sorry, but I don't have the runtime exceptions around anymore to post.
>
> -Donald
>
> jason.dillon@gmail.com wrote:
>> What is broken?  As I have said before the build worked fine for  
>> me. Please explain in more detail why these changes are required.  
>> --jason
>> -----Original Message-----
>> From: dwoods@apache.org
>> Date: Wed, 06 Jun 2007 18:38:47 To:scm@geronimo.apache.org
>> Subject: svn commit: r544915 - in
>>  /geronimo/server/trunk/applications/geronimo-examples/geronimo- 
>> jsp-examples:
>>  pom.xml src/main/webapp/WEB-INF/jsp/debug-taglib.tld
>>  src/main/webapp/WEB-INF/jsp/example-taglib.tld src/main/webapp/ 
>> WEB-INF/lib/
>> Author: dwoods
>> Date: Wed Jun  6 11:38:46 2007
>> New Revision: 544915
>> URL: http://svn.apache.org/viewvc?view=rev&rev=544915
>> Log:
>> GERONIMO-3215 Correct deployment errors with jsp-examples sample.   
>> Removed jspc-maven-plugin usage as it breaks the sample and isn't  
>> worth the time to fix it....
>> Removed:
>>     geronimo/server/trunk/applications/geronimo-examples/geronimo- 
>> jsp-examples/src/main/webapp/WEB-INF/lib/
>> Modified:
>>     geronimo/server/trunk/applications/geronimo-examples/geronimo- 
>> jsp-examples/pom.xml
>>     geronimo/server/trunk/applications/geronimo-examples/geronimo- 
>> jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld
>>     geronimo/server/trunk/applications/geronimo-examples/geronimo- 
>> jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld
>> Modified: geronimo/server/trunk/applications/geronimo-examples/ 
>> geronimo-jsp-examples/pom.xml
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
>> applications/geronimo-examples/geronimo-jsp-examples/pom.xml? 
>> view=diff&rev=544915&r1=544914&r2=544915
>> ===================================================================== 
>> =========
>> --- geronimo/server/trunk/applications/geronimo-examples/geronimo- 
>> jsp-examples/pom.xml (original)
>> +++ geronimo/server/trunk/applications/geronimo-examples/geronimo- 
>> jsp-examples/pom.xml Wed Jun  6 11:38:46 2007
>> @@ -58,13 +58,11 @@
>>      <build>
>>          <plugins>
>>              <plugin>
>> -                <groupId>org.codehaus.mojo.jspc</groupId>
>> -                <artifactId>jspc-maven-plugin</artifactId>
>> -            </plugin>
>> -            -            <plugin>
>>                  <groupId>org.apache.maven.plugins</groupId>
>>                  <artifactId>maven-war-plugin</artifactId>
>> +                <configuration>
>> +                    <webXml>${pom.basedir}/src/main/webapp/WEB- 
>> INF/web.xml</webXml>
>> +                </configuration>
>>              </plugin>
>>          </plugins>
>>      </build>
>> Modified: geronimo/server/trunk/applications/geronimo-examples/ 
>> geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
>> applications/geronimo-examples/geronimo-jsp-examples/src/main/ 
>> webapp/WEB-INF/jsp/debug-taglib.tld? 
>> view=diff&rev=544915&r1=544914&r2=544915
>> ===================================================================== 
>> =========
>> --- geronimo/server/trunk/applications/geronimo-examples/geronimo- 
>> jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld (original)
>> +++ geronimo/server/trunk/applications/geronimo-examples/geronimo- 
>> jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld Wed Jun   
>> 6 11:38:46 2007
>> @@ -40,7 +40,7 @@
>>    <tag>
>>      <name>log</name>
>>      <tag-class>examples.LogTag</tag-class>
>> -    <body-content>TAGDEPENDENT</body-content>
>> +    <body-content>tagdependent</body-content>
>>      <description>
>>  	Perform a server side action; Log the message.
>>      </description>
>> Modified: geronimo/server/trunk/applications/geronimo-examples/ 
>> geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
>> applications/geronimo-examples/geronimo-jsp-examples/src/main/ 
>> webapp/WEB-INF/jsp/example-taglib.tld? 
>> view=diff&rev=544915&r1=544914&r2=544915
>> ===================================================================== 
>> =========
>> --- geronimo/server/trunk/applications/geronimo-examples/geronimo- 
>> jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld  
>> (original)
>> +++ geronimo/server/trunk/applications/geronimo-examples/geronimo- 
>> jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld Wed  
>> Jun  6 11:38:46 2007
>> @@ -70,7 +70,7 @@
>>    <tag>
>>      <name>log</name>
>>      <tag-class>examples.LogTag</tag-class>
>> -    <body-content>TAGDEPENDENT</body-content>
>> +    <body-content>tagdependent</body-content>
>>      <description>
>>  	Perform a server side action; Log the message.
>>      </description>


Re: svn commit: r544915 - in/geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples:pom.xml src/main/webapp/WEB-INF/jsp/debug-taglib.tldsrc/main/webapp/WEB-INF/jsp/example-taglib.tld src/main/webapp/WEB-INF/lib/

Posted by Donald Woods <dw...@apache.org>.
When the sample is deployed as a WAR file (and not installed as a CAR/Plugin) 
the sample JSP apps fail, due to a corrupted web.xml....
Sorry, but I don't have the runtime exceptions around anymore to post.

-Donald

jason.dillon@gmail.com wrote:
> What is broken?  As I have said before the build worked fine for me. Please explain in more detail why these changes are required. 
> 
> --jason
> 
> 
> -----Original Message-----
> From: dwoods@apache.org
> 
> Date: Wed, 06 Jun 2007 18:38:47 
> To:scm@geronimo.apache.org
> Subject: svn commit: r544915 - in
>  /geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples:
>  pom.xml src/main/webapp/WEB-INF/jsp/debug-taglib.tld
>  src/main/webapp/WEB-INF/jsp/example-taglib.tld src/main/webapp/WEB-INF/lib/
> 
> 
> Author: dwoods
> Date: Wed Jun  6 11:38:46 2007
> New Revision: 544915
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=544915
> Log:
> GERONIMO-3215 Correct deployment errors with jsp-examples sample.  Removed jspc-maven-plugin usage as it breaks the sample and isn't worth the time to fix it....
> 
> Removed:
>     geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/lib/
> Modified:
>     geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/pom.xml
>     geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld
>     geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld
> 
> Modified: geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/pom.xml?view=diff&rev=544915&r1=544914&r2=544915
> ==============================================================================
> --- geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/pom.xml (original)
> +++ geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/pom.xml Wed Jun  6 11:38:46 2007
> @@ -58,13 +58,11 @@
>      <build>
>          <plugins>
>              <plugin>
> -                <groupId>org.codehaus.mojo.jspc</groupId>
> -                <artifactId>jspc-maven-plugin</artifactId>
> -            </plugin>
> -            
> -            <plugin>
>                  <groupId>org.apache.maven.plugins</groupId>
>                  <artifactId>maven-war-plugin</artifactId>
> +                <configuration>
> +                    <webXml>${pom.basedir}/src/main/webapp/WEB-INF/web.xml</webXml>
> +                </configuration>
>              </plugin>
>          </plugins>
>      </build>
> 
> Modified: geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld?view=diff&rev=544915&r1=544914&r2=544915
> ==============================================================================
> --- geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld (original)
> +++ geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/debug-taglib.tld Wed Jun  6 11:38:46 2007
> @@ -40,7 +40,7 @@
>    <tag>
>      <name>log</name>
>      <tag-class>examples.LogTag</tag-class>
> -    <body-content>TAGDEPENDENT</body-content>
> +    <body-content>tagdependent</body-content>
>      <description>
>  	Perform a server side action; Log the message.
>      </description>
> 
> Modified: geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld?view=diff&rev=544915&r1=544914&r2=544915
> ==============================================================================
> --- geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld (original)
> +++ geronimo/server/trunk/applications/geronimo-examples/geronimo-jsp-examples/src/main/webapp/WEB-INF/jsp/example-taglib.tld Wed Jun  6 11:38:46 2007
> @@ -70,7 +70,7 @@
>    <tag>
>      <name>log</name>
>      <tag-class>examples.LogTag</tag-class>
> -    <body-content>TAGDEPENDENT</body-content>
> +    <body-content>tagdependent</body-content>
>      <description>
>  	Perform a server side action; Log the message.
>      </description>
> 
>