[spark] branch master updated: [SPARK-36890][K8S] Use default WebsocketPingInterval for Kubernetes watches

[do...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 457b75e  [SPARK-36890][K8S] Use default WebsocketPingInterval for Kubernetes watches
457b75e is described below

commit 457b75ea2bca6b5811d61ce9f1d28c94b0dde3a2
Author: Philipp Dallig <ph...@gmail.com>
AuthorDate: Tue Oct 26 00:47:58 2021 -0700

    [SPARK-36890][K8S] Use default WebsocketPingInterval for Kubernetes watches
    
    ### What changes were proposed in this pull request?
    This pull request removes the configuration that disables the WebsocketPingInterval. The default value of the [fabric8io/kubernetes-client](https://github.com/fabric8io/kubernetes-client/blob/master/README.md) library is 30 seconds.
    
    Users still can fallback to `0` if needed.
    ```
    export KUBERNETES_WEBSOCKET_PING_INTERVAL=0
    ```
    
    ### Why are the changes needed?
    With a periodical websocket ping, the tunnel timeout in loadbalancers should work as expected.
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    It is not possible for me to write a test for this particular infrastructure. I have checked the setting locally within my infrastructure.
    
    Closes #34143 from Reamer/k8s_api_websocket_ping.
    
    Authored-by: Philipp Dallig <ph...@gmail.com>
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
 .../scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala | 1 -
 1 file changed, 1 deletion(-)

diff --git a/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala b/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
index 191cd3d..4131605 100644
--- a/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
+++ b/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
@@ -88,7 +88,6 @@ private[spark] object SparkKubernetesClientFactory extends Logging {
     val config = new ConfigBuilder(autoConfigure(kubeContext.getOrElse(null)))
       .withApiVersion("v1")
       .withMasterUrl(master)
-      .withWebsocketPingInterval(0)
       .withRequestTimeout(clientType.requestTimeout(sparkConf))
       .withConnectionTimeout(clientType.connectionTimeout(sparkConf))
       .withTrustCerts(sparkConf.get(KUBERNETES_TRUST_CERTIFICATES))

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org