[jira] [Commented] (BEAM-59) IOChannelFactory rethinking/redesign

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972023#comment-15972023 ] 

ASF GitHub Bot commented on BEAM-59:
------------------------------------

GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/2563

    [BEAM-59] FileBasedSource: convert to FileSystem from IOChannelFactory

    Accompanying changes:
    
    * And change all the FileBasedSource implementations in the SDK.
    * Drop a few FileBasedSource.readFromX functions that are not
      style-compliant.
    * Add a few allowsDynamicSplitting overrides to FileBasedReaders where
      it's needed.
    * Since the FileSystem API can preserve the size information from
      listing in external file systems, get rid of all the sampling logic
      in FileBasedSource -- we can always use the exact size.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam convert-filebasedsource

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2563.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2563
    
----
commit ecf7082fc034bbeb5f6980ad581ce0683934a7f6
Author: Dan Halperin <dh...@google.com>
Date:   2017-04-14T15:52:42Z

    FileBasedSource: convert to FileSystem from IOChannelFactory
    
    Other stuff:
    
    * And change all the FileBasedSource implementations in the SDK.
    * Drop a few FileBasedSource.readFromX functions that are not
      style-compliant.
    * Add a few allowsDynamicSplitting overrides to FileBasedReaders where
      it's needed.
    * Since the FileSystem API can preserve the size information from
      listing in external file systems, get rid of all the sampling logic
      in FileBasedSource -- we can always use the exact size.

----


> IOChannelFactory rethinking/redesign
> ------------------------------------
>
>                 Key: BEAM-59
>                 URL: https://issues.apache.org/jira/browse/BEAM-59
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core, sdk-java-gcp
>            Reporter: Daniel Halperin
>            Assignee: Pei He
>             Fix For: First stable release
>
>
> Right now, FileBasedSource and FileBasedSink communication is mediated by IOChannelFactory. There are a number of issues:
> * Global configuration -- e.g., all 'gs://' URIs use the same credentials. This should be per-source/per-sink/etc.
> * Supported APIs -- currently IOChannelFactory is in the "non-public API" util package and subject to change. We need users to be able to add new backends ('s3://', 'hdfs://', etc.) directly, without fear that they will be broken.
> * Per-backend features: e.g., creating buckets in GCS/s3, setting expiration time, etc.
> Updates:
> Design docs posted on dev@ list:
> Part 1: IOChannelFactory Redesign: 
> https://docs.google.com/document/d/11TdPyZ9_zmjokhNWM3Id-XJsVG3qel2lhdKTknmZ_7M/edit#
> Part 2: Configurable BeamFileSystem:
> https://docs.google.com/document/d/1-7vo9nLRsEEzDGnb562PuL4q9mUiq_ZVpCAiyyJw8p8/edit#heading=h.p3gc3colc2cs



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)