You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by hu...@apache.org on 2018/04/19 06:02:11 UTC
[incubator-dubbo.wiki] branch master updated: Add sending pull
request and code convention section to new contributor guide.
This is an automated email from the ASF dual-hosted git repository.
huxing pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.wiki.git
The following commit(s) were added to refs/heads/master by this push:
new 93ef305 Add sending pull request and code convention section to new contributor guide.
93ef305 is described below
commit 93ef3056423d4973acdcc4bc1106dd70a5c9f5c3
Author: Huxing Zhang <hu...@gmail.com>
AuthorDate: Thu Apr 19 14:02:09 2018 +0800
Add sending pull request and code convention section to new contributor guide.
---
New-contributor-guide.md | 25 ++++++++++++++++++++++++-
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/New-contributor-guide.md b/New-contributor-guide.md
index eb2d6c6..f49593c 100644
--- a/New-contributor-guide.md
+++ b/New-contributor-guide.md
@@ -6,4 +6,27 @@ The mailing list is the recommended way for discussing almost anything that rela
* dev@dubbo.incubator.apache.org: the develop mailing list, you can ask question here if you have encountered any problem when using or developing Dubbo.
* commits@dubbo.incubator.apache.org: all the commits will be sent to this mailing list. You can subscribe to it if you are interested in Dubbo's development.
-* issues@dubbo.incubator.apache.org: all the JIRA [issues](https://issues.apache.org/jira/projects/DUBBO/issues) and updates will be sent to this mailing list. The Dubbo community has decided to use github issues rather than JIRA issues, therefore it is expected that most of the issues will be tracked by github issues. The JIRA issues are used to track ASF related issues.
\ No newline at end of file
+* issues@dubbo.incubator.apache.org: all the JIRA [issues](https://issues.apache.org/jira/projects/DUBBO/issues) and updates will be sent to this mailing list. The Dubbo community has decided to use github issues rather than JIRA issues, therefore it is expected that most of the issues will be tracked by github issues. The JIRA issues are used to track ASF related issues.
+
+
+### Reporting issue
+
+### Sending pull request
+
+* Follow the checklist in the [pull request template](https://github.com/apache/incubator-dubbo/blob/master/PULL_REQUEST_TEMPLATE.md)
+* Before you sending out the pull request, please sync your forked repository with remote repository, this will make your pull request simple and clear. See guide below:
+
+```sh
+git remote add upstream git@github.com:apache/incubator-dubbo.git
+git fetch upstream
+git rebase upstream/master
+git checkout -b your_awesome_patch
+... add some work
+git push origin your_awesome_patch
+```
+
+
+### Code convention
+
+Please check the [CONTRIBUTING.md](https://github.com/apache/incubator-dubbo/blob/master/CONTRIBUTING.md) for code convention.
+
--
To stop receiving notification emails like this one, please contact
huxing@apache.org.