You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/07 10:12:08 UTC
[GitHub] [pulsar] AlvaroStream opened a new pull request, #17958: [Improve][doc] Insist about default behaviour for retention.
AlvaroStream opened a new pull request, #17958:
URL: https://github.com/apache/pulsar/pull/17958
I was looking for the default and I didn't notice that over was properly mentioned.
### Motivation
Small improvement to remind about the default behaviour.
### Modifications
Simple modification.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] Anything that affects deployment
### Documentation
- [ X ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/AlvaroStream/pulsar/tree/patch-6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #17958: [Improve][doc] Insist about default behaviour for retention.
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #17958:
URL: https://github.com/apache/pulsar/pull/17958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on pull request #17958: [Improve][doc] Insist about default behaviour for retention.
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on PR #17958:
URL: https://github.com/apache/pulsar/pull/17958#issuecomment-1272307884
@AlvaroStream thanks for your contribution. Could you please help whether docs in other releases also need to be updated? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a diff in pull request #17958: [Improve][doc] Insist about default behaviour for retention.
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on code in PR #17958:
URL: https://github.com/apache/pulsar/pull/17958#discussion_r990636171
##########
site2/docs/cookbooks-retention-expiry.md:
##########
@@ -58,7 +58,7 @@ When a retention limit on a topic is exceeded, the oldest message is marked for
### Defaults
-You can set message retention at instance level with the following two parameters: `defaultRetentionTimeInMinutes` and `defaultRetentionSizeInMB`. Both parameters are set to `0` by default.
+You can set message retention at instance level with the following two parameters: `defaultRetentionTimeInMinutes` and `defaultRetentionSizeInMB`. Both parameters are set to `0` by default that means "Disable message retention".
Review Comment:
```suggestion
You can set message retention at instance level with the following two parameters: `defaultRetentionTimeInMinutes` and `defaultRetentionSizeInMB`. By default, both parameters are set to `0`, which means disabling message retention.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #17958: [Improve][doc] Insist about default behaviour for retention.
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #17958:
URL: https://github.com/apache/pulsar/pull/17958#issuecomment-1275508435
@AlvaroStream .md doc PR does not need this
https://github.com/apache/pulsar/blob/2dfdf44dd9a19cf0cc255f874fced45529487350/.github/changes-filter.yaml#L9
<img width="589" alt="image" src="https://user-images.githubusercontent.com/50226895/195236870-b171a434-659c-4d4a-91db-b609927ff502.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org