[jira] [Resolved] (KAFKA-7496) KafkaAdminClient#describeAcls should handle invalid filters gracefully

["Rajini Sivaram (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rajini Sivaram resolved KAFKA-7496.
-----------------------------------
       Resolution: Fixed
         Reviewer: Rajini Sivaram
    Fix Version/s: 2.1.0

> KafkaAdminClient#describeAcls should handle invalid filters gracefully
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-7496
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7496
>             Project: Kafka
>          Issue Type: Bug
>          Components: admin
>            Reporter: Colin P. McCabe
>            Assignee: Colin P. McCabe
>            Priority: Minor
>             Fix For: 2.1.0
>
>
> KafkaAdminClient#describeAcls should handle invalid filters gracefully.  Specifically, it should return a future which yields an exception.
> The following code results in an uncaught IllegalArgumentException in the admin client thread, resulting in a zombie admin client.
> {code}
> AclBindingFilter aclFilter = new AclBindingFilter(
>     new ResourcePatternFilter(ResourceType.UNKNOWN, null, PatternType.ANY),
>     AccessControlEntryFilter.ANY
> );
> kafkaAdminClient.describeAcls(aclFilter).values().get();
> {code}
> See the resulting stacktrace below
> {code}
> ERROR [kafka-admin-client-thread | adminclient-3] Uncaught exception in thread 'kafka-admin-client-thread | adminclient-3': (org.apache.kafka.common.utils.KafkaThread)
> java.lang.IllegalArgumentException: Filter contain UNKNOWN elements
>     at org.apache.kafka.common.requests.DescribeAclsRequest.validate(DescribeAclsRequest.java:140)
>     at org.apache.kafka.common.requests.DescribeAclsRequest.<init>(DescribeAclsRequest.java:92)
>     at org.apache.kafka.common.requests.DescribeAclsRequest$Builder.build(DescribeAclsRequest.java:77)
>     at org.apache.kafka.common.requests.DescribeAclsRequest$Builder.build(DescribeAclsRequest.java:67)
>     at org.apache.kafka.clients.NetworkClient.doSend(NetworkClient.java:450)
>     at org.apache.kafka.clients.NetworkClient.send(NetworkClient.java:411)
>     at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.sendEligibleCalls(KafkaAdminClient.java:910)
>     at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.run(KafkaAdminClient.java:1107)
>     at java.base/java.lang.Thread.run(Thread.java:844)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)