You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "amaliujia (via GitHub)" <gi...@apache.org> on 2023/06/07 03:02:50 UTC
[GitHub] [spark] amaliujia commented on a diff in pull request #41461: [SPARK-43961][SQL][PYTHON][CONNECT] Add optional pattern for Catalog.listTables
amaliujia commented on code in PR #41461:
URL: https://github.com/apache/spark/pull/41461#discussion_r1220752992
##########
connector/connect/common/src/main/protobuf/spark/connect/catalog.proto:
##########
@@ -77,6 +77,8 @@ message ListDatabases {
message ListTables {
// (Optional)
optional string db_name = 1;
+ // (Optional) The pattern that the table name needs to match
+ optional string pattern = 2;
Review Comment:
Do we need a test case for Spark Connect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org