You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by sv...@apache.org on 2014/06/04 17:59:32 UTC
git commit: WICKET-5606 improved javadoc for setRecreateChoices()
Repository: wicket
Updated Branches:
refs/heads/master af400d80f -> 405626310
WICKET-5606 improved javadoc for setRecreateChoices()
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/40562631
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/40562631
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/40562631
Branch: refs/heads/master
Commit: 40562631077acd2afa2f384bf84c449fb03b3c67
Parents: af400d8
Author: svenmeier <sv...@meiers.net>
Authored: Wed Jun 4 17:58:30 2014 +0200
Committer: svenmeier <sv...@meiers.net>
Committed: Wed Jun 4 17:58:30 2014 +0200
----------------------------------------------------------------------
.../extensions/markup/html/form/select/SelectOptions.java | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/40562631/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOptions.java
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOptions.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOptions.java
index 692dd05..1b2ed77 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOptions.java
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOptions.java
@@ -78,10 +78,16 @@ public class SelectOptions<T> extends RepeatingView
}
/**
- * Controls whether or not SelectChoice objects are recreated every request
+ * Controls whether {@link SelectOption}s are recreated on every request
+ * <p>
+ * Note: When refreshing on each render, {@link #newOption(String, IModel)} should return
+ * {@link SelectOption}s with stable values, otherwise the current selection will be lost on
+ * form errors.
*
* @param refresh
* @return this for chaining
+ *
+ * @see SelectOption#getValue()
*/
public SelectOptions<T> setRecreateChoices(final boolean refresh)
{