You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by alasdairhodge <gi...@git.apache.org> on 2015/08/19 11:34:13 UTC
[GitHub] incubator-brooklyn pull request: Add missing lib\ segment to libra...
GitHub user alasdairhodge opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/845
Add missing lib\ segment to library ’patch’ dir
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alasdairhodge/incubator-brooklyn fix/windows-classpath
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/845.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #845
----
commit f44678d42272e97e2dc5213f773610bb976a5a8b
Author: Alasdair Hodge <gi...@alasdairhodge.co.uk>
Date: 2015-08-19T09:33:26Z
Add missing lib\ segment to library ’patch’ dir
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix launch classpath on Windows
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/845
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix launch classpath on Windows
Posted by alasdairhodge <gi...@git.apache.org>.
Github user alasdairhodge commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/845#issuecomment-132528496
Thanks, @sjcorbett; now pushed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix launch classpath on Windows
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/845#issuecomment-132525891
@alasdairhodge Your commit hasn't touched dropins. Have you pushed everything?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix launch classpath on Windows
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/845#issuecomment-132529059
LGTM. And this shouldn't conflict with the package renaming :) so good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---