You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Sijie Guo <gu...@gmail.com> on 2015/11/12 10:53:12 UTC
Review Request 40223: BOOKKEEPER-438: Move ledger id generation out of
LedgerManager
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40223/
-----------------------------------------------------------
Review request for bookkeeper.
Bugs: BOOKKEEPER-438
https://issues.apache.org/jira/browse/BOOKKEEPER-438
Repository: bookkeeper-git
Description
-------
Move id generation out of LedgerManager to ensure different ledger manager implementation shared same ledger id space in ZooKeeper, which is necessary for migration between different ledger managers.
Diffs
-----
CHANGES.txt 378ae55c1e734eea3f95323182decbae93176e7a
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java c5be32d543da38655f09cff31a15cfe124e73e4f
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java 49d8e5915d762dc2971d70dbf28517ffbe705e10
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java fe223af959228c34482ce9c96b25c4559858494b
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java 3ec2b5a1c305a8807d1299b36b99af51b022ab71
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java f3f680d81f13f4cec9f771e117ccb489efd65c16
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java a7fbcf500ff1f8f5cb48d08b116913a1162b7e97
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java 2bc42580f4ae87784f44910009821c5c77553e9c
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java db16d26b1672ce4f549d9d4010307e7924475db8
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java 7f2df736bc1e511f0c4eafcfb0d9ede140f8e84c
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java b843e994af49da314d17204110a191968e685220
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerIdGenerator.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 72290286e1b0227db0b712393411b34a34db0731
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java 7c3cf5c994c7a8a61e8ad1cea70bab9c0c2720ec
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MSLedgerManagerFactory.java 2510b89d749f3123f0ea225b3396d1e84e28f292
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkLedgerIdGenerator.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CompactionTest.java 956595e168b9bc6c0a7d1811c68f6347d6d72f39
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestWatchEnsembleChange.java eb833a3e0d554ff223024e5ada540d4911d91a16
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 19aab44e772d5ecaa83acf9ebc83d6f54ac56f13
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java b95d2db4574c5c1a7f6c60907b7e6f12c511e84f
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestZkLedgerIdGenerator.java PRE-CREATION
Diff: https://reviews.apache.org/r/40223/diff/
Testing
-------
Thanks,
Sijie Guo
Re: Review Request 40223: BOOKKEEPER-438: Move ledger id generation
out of LedgerManager
Posted by Matteo Merli <mm...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40223/#review106374
-----------------------------------------------------------
Ship it!
Ship It!
- Matteo Merli
On Nov. 12, 2015, 9:53 a.m., Sijie Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40223/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 9:53 a.m.)
>
>
> Review request for bookkeeper.
>
>
> Bugs: BOOKKEEPER-438
> https://issues.apache.org/jira/browse/BOOKKEEPER-438
>
>
> Repository: bookkeeper-git
>
>
> Description
> -------
>
> Move id generation out of LedgerManager to ensure different ledger manager implementation shared same ledger id space in ZooKeeper, which is necessary for migration between different ledger managers.
>
>
> Diffs
> -----
>
> CHANGES.txt 378ae55c1e734eea3f95323182decbae93176e7a
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java c5be32d543da38655f09cff31a15cfe124e73e4f
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java 49d8e5915d762dc2971d70dbf28517ffbe705e10
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java fe223af959228c34482ce9c96b25c4559858494b
> bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java 3ec2b5a1c305a8807d1299b36b99af51b022ab71
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java f3f680d81f13f4cec9f771e117ccb489efd65c16
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/CleanupLedgerManager.java a7fbcf500ff1f8f5cb48d08b116913a1162b7e97
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java 2bc42580f4ae87784f44910009821c5c77553e9c
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java db16d26b1672ce4f549d9d4010307e7924475db8
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java 7f2df736bc1e511f0c4eafcfb0d9ede140f8e84c
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java b843e994af49da314d17204110a191968e685220
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerIdGenerator.java PRE-CREATION
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 72290286e1b0227db0b712393411b34a34db0731
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java 7c3cf5c994c7a8a61e8ad1cea70bab9c0c2720ec
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/MSLedgerManagerFactory.java 2510b89d749f3123f0ea225b3396d1e84e28f292
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkLedgerIdGenerator.java PRE-CREATION
> bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CompactionTest.java 956595e168b9bc6c0a7d1811c68f6347d6d72f39
> bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestWatchEnsembleChange.java eb833a3e0d554ff223024e5ada540d4911d91a16
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 19aab44e772d5ecaa83acf9ebc83d6f54ac56f13
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java b95d2db4574c5c1a7f6c60907b7e6f12c511e84f
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestZkLedgerIdGenerator.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40223/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sijie Guo
>
>