You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/02/05 01:09:31 UTC
Review Request: Added --disable-perftools to configure.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9296/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
See MESOS-331 for background info.
This addresses bug MESOS-331.
https://issues.apache.org/jira/browse/MESOS-331
Diffs
-----
src/python/setup.py.in f0bddf403f22d59640975ddd2f456eec18d24414
third_party/libprocess/Makefile.am dad1b65c3fdb7dbdad4e7c3d9c241cc4e89c3325
third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75
third_party/libprocess/include/process/profiler.hpp 5e32a9e8b53a63b4959fbbc0d5ed39ea53f24cf8
third_party/libprocess/third_party/Makefile.am 58ebb293d6b687cfd7daf5343c4b3c3c9e47bf0c
Diff: https://reviews.apache.org/r/9296/diff/
Testing
-------
Tested with both:
../configure
../configure --disable-perftools
Thanks,
Ben Mahler
Re: Review Request: Added --disable-perftools to configure.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9296/#review16141
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 5, 2013, 12:09 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9296/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2013, 12:09 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See MESOS-331 for background info.
>
>
> This addresses bug MESOS-331.
> https://issues.apache.org/jira/browse/MESOS-331
>
>
> Diffs
> -----
>
> src/python/setup.py.in f0bddf403f22d59640975ddd2f456eec18d24414
> third_party/libprocess/Makefile.am dad1b65c3fdb7dbdad4e7c3d9c241cc4e89c3325
> third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75
> third_party/libprocess/include/process/profiler.hpp 5e32a9e8b53a63b4959fbbc0d5ed39ea53f24cf8
> third_party/libprocess/third_party/Makefile.am 58ebb293d6b687cfd7daf5343c4b3c3c9e47bf0c
>
> Diff: https://reviews.apache.org/r/9296/diff/
>
>
> Testing
> -------
>
> Tested with both:
> ../configure
> ../configure --disable-perftools
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added --disable-perftools to configure.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9296/#review16791
-----------------------------------------------------------
Ship it!
third_party/libprocess/include/process/profiler.hpp
<https://reviews.apache.org/r/9296/#comment35673>
Maybe avoid the double negative?
- Benjamin Hindman
On Feb. 5, 2013, 12:09 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9296/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2013, 12:09 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See MESOS-331 for background info.
>
>
> This addresses bug MESOS-331.
> https://issues.apache.org/jira/browse/MESOS-331
>
>
> Diffs
> -----
>
> src/python/setup.py.in f0bddf403f22d59640975ddd2f456eec18d24414
> third_party/libprocess/Makefile.am dad1b65c3fdb7dbdad4e7c3d9c241cc4e89c3325
> third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75
> third_party/libprocess/include/process/profiler.hpp 5e32a9e8b53a63b4959fbbc0d5ed39ea53f24cf8
> third_party/libprocess/third_party/Makefile.am 58ebb293d6b687cfd7daf5343c4b3c3c9e47bf0c
>
> Diff: https://reviews.apache.org/r/9296/diff/
>
>
> Testing
> -------
>
> Tested with both:
> ../configure
> ../configure --disable-perftools
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added --disable-perftools to configure.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9296/
-----------------------------------------------------------
(Updated Feb. 25, 2013, 9:40 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased.
Description
-------
See MESOS-331 for background info.
This addresses bug MESOS-331.
https://issues.apache.org/jira/browse/MESOS-331
Diffs (updated)
-----
src/python/setup.py.in f0bddf403f22d59640975ddd2f456eec18d24414
third_party/libprocess/Makefile.am bbdd282fcc38a34f5e0142a3e2e021ee37ff8733
third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75
third_party/libprocess/include/process/profiler.hpp 0bb0fb4970f2478ccd9ddd29c95e806c9d2a5253
third_party/libprocess/third_party/Makefile.am 5c63c805229e6d7b98aa1fb85f0fe7276110b7f3
Diff: https://reviews.apache.org/r/9296/diff/
Testing
-------
Tested with both:
../configure
../configure --disable-perftools
Thanks,
Ben Mahler
Re: Review Request: Added --disable-perftools to configure.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9296/
-----------------------------------------------------------
(Updated Feb. 20, 2013, 10:01 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Re-phrased the response message to avoid the double negative.
Description
-------
See MESOS-331 for background info.
This addresses bug MESOS-331.
https://issues.apache.org/jira/browse/MESOS-331
Diffs (updated)
-----
src/python/setup.py.in f0bddf403f22d59640975ddd2f456eec18d24414
third_party/libprocess/Makefile.am dad1b65c3fdb7dbdad4e7c3d9c241cc4e89c3325
third_party/libprocess/configure.ac f5699fa716ef75decfaaefc753d3a9463668fc75
third_party/libprocess/include/process/profiler.hpp 5e32a9e8b53a63b4959fbbc0d5ed39ea53f24cf8
third_party/libprocess/third_party/Makefile.am 58ebb293d6b687cfd7daf5343c4b3c3c9e47bf0c
Diff: https://reviews.apache.org/r/9296/diff/
Testing
-------
Tested with both:
../configure
../configure --disable-perftools
Thanks,
Ben Mahler