You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/24 03:19:52 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #7349: Merge
additional changes in lyftga to master
codecov-io commented on issue #7349: Merge additional changes in lyftga to master
URL: https://github.com/apache/incubator-superset/pull/7349#issuecomment-486051883
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7349?src=pr&el=h1) Report
> Merging [#7349](https://codecov.io/gh/apache/incubator-superset/pull/7349?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/845218dd88ad2fe1284dcb7427c5bff20749dc74?src=pr&el=desc) will **increase** coverage by `1.57%`.
> The diff coverage is `40%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/7349?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7349 +/- ##
==========================================
+ Coverage 64.89% 66.47% +1.57%
==========================================
Files 428 429 +1
Lines 20937 23139 +2202
Branches 2330 2513 +183
==========================================
+ Hits 13588 15381 +1793
- Misses 7225 7621 +396
- Partials 124 137 +13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7349?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7349/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydC5qc3g=) | `12.5% <0%> (ø)` | :arrow_up: |
| [...rset/assets/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7349/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `43.9% <0%> (ø)` | :arrow_up: |
| [...uperset/assets/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7349/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXIuanN4) | `42.2% <0%> (ø)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7349/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `78.83% <0%> (+5.93%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/7349/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `93.78% <100%> (ø)` | :arrow_up: |
| [superset/assets/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/7349/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9mZWF0dXJlRmxhZ3MudHM=) | `75% <100%> (+3.57%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7349/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.46% <50%> (-0.11%)` | :arrow_down: |
| [superset/assets/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/7349/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9jaGFydEFjdGlvbi5qcw==) | `49.25% <66.66%> (+0.01%)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/7349/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.56% <83.33%> (+0.02%)` | :arrow_up: |
| [superset/legacy.py](https://codecov.io/gh/apache/incubator-superset/pull/7349/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbGVnYWN5LnB5) | `14.7% <0%> (-85.3%)` | :arrow_down: |
| ... and [45 more](https://codecov.io/gh/apache/incubator-superset/pull/7349/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7349?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7349?src=pr&el=footer). Last update [845218d...cb7c806](https://codecov.io/gh/apache/incubator-superset/pull/7349?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org