[GitHub] [fineract] ptuomola commented on pull request #1166: FINERACT-1054 fixed sql grammar at loan repayment

[GitBox <gi...@apache.org>]

ptuomola commented on pull request #1166:
URL: https://github.com/apache/fineract/pull/1166#issuecomment-660794602


   @vorburger Unfortunately I'm not familiar with the business functionality here - i.e. in what scenarios will we end up with multiple rows for the same due date that need to be grouped - and when we do, how do these rows differ? 
   
   I agree that this change should fix the SQL error. But just not sure if there are any cases where we would end up with different behaviour than before: i.e. previously we would have had one row returned with values picked at random from the rows being grouped, and now we would end up with multiple rows being returned. If we know that in all cases the rows with the same due date will also have the same other values, then this will naturally never happen...
   
   Having said that, at the moment it clearly does not work at all but throws an SQL error - so this is definitely an improvement regardless!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org