You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2023/05/22 17:27:54 UTC
[GitHub] [pinot] Jackie-Jiang opened a new issue, #10793: Ensure min/max value are always generated in the segment metadata
Jackie-Jiang opened a new issue, #10793:
URL: https://github.com/apache/pinot/issues/10793
Min/max value are very useful for segment pruning and also index creation (e.g. range index)
Currently min/max value might not be generated in certain cases:
- Metric aggregation column
- min/max value is too long (for string/bytes)
For the first case, or existing segment without min/max value, we can enhance `ColumnMinMaxValueGenerator` to scan the values and fill the min/max value
For the second case, we can trim the long value and store the closest min/max value instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] abhioncbr commented on issue #10793: Ensure min/max value are always generated in the segment metadata
Posted by "abhioncbr (via GitHub)" <gi...@apache.org>.
abhioncbr commented on issue #10793:
URL: https://github.com/apache/pinot/issues/10793#issuecomment-1585991309
@Jackie-Jiang, I need more pointers wrt to the metric aggregation column.
In the `ALL` columns mode, we generate min/max for all the columns. What would be the possible reason for missing the min/max value for the metric aggregation column? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang closed issue #10793: Ensure min/max value are always generated in the segment metadata
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang closed issue #10793: Ensure min/max value are always generated in the segment metadata
URL: https://github.com/apache/pinot/issues/10793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] abhioncbr commented on issue #10793: Ensure min/max value are always generated in the segment metadata
Posted by "abhioncbr (via GitHub)" <gi...@apache.org>.
abhioncbr commented on issue #10793:
URL: https://github.com/apache/pinot/issues/10793#issuecomment-1650815745
We can close this issue. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] abhioncbr commented on issue #10793: Ensure min/max value are always generated in the segment metadata
Posted by "abhioncbr (via GitHub)" <gi...@apache.org>.
abhioncbr commented on issue #10793:
URL: https://github.com/apache/pinot/issues/10793#issuecomment-1559883755
Please assign this issue to me if no one is working on it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #10793: Ensure min/max value are always generated in the segment metadata
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #10793:
URL: https://github.com/apache/pinot/issues/10793#issuecomment-1590195526
> In the `ALL` columns mode, we generate min/max for all the columns. What would be the possible reason for missing the min/max value for the metric aggregation column? Thanks
When a column doesn't have dictionary, `ColumnMinMaxValueGenerator` won't scan the values and fill the min/max value currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org