You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2016/04/05 21:00:55 UTC
Re: Review Request 45495: Removed custom clone functions from Mesos
[5/5].
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45495/#review127185
-----------------------------------------------------------
src/slave/containerizer/mesos/linux_launcher.cpp (line 279)
<https://reviews.apache.org/r/45495/#comment190349>
`SIGCHLD` is not a namespace flag, right?
See my earlier comment about renaming the `namespace` flags.
- Joris Van Remoortere
On March 31, 2016, 10:24 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45495/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 10:24 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-5071
> https://issues.apache.org/jira/browse/MESOS-5071
>
>
> Repository: mesos
>
>
> Description
> -------
>
> All existing clone calls can be specified by providing namespace flags
> to subprocess directly.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5
> src/slave/container_loggers/lib_logrotate.cpp 1f228806da32832c9ca1ae4defcd1bdc154adc18
> src/slave/containerizer/docker.cpp c5007a311ae9c1766dd4522ccbddbdb506d4ae4e
> src/slave/containerizer/external_containerizer.cpp cf4384cce44172a028c890f52f71ceb8ae109383
> src/slave/containerizer/mesos/isolators/posix/disk.cpp dde958b252eae75563003ec15087b4231beb285a
> src/slave/containerizer/mesos/launcher.cpp a5c8c31b72773d0bd10b9d02675a01f1d641d41c
> src/slave/containerizer/mesos/linux_launcher.cpp 5028854fa003615f158120e030866b7ec4402b66
> src/tests/containerizer/launch_tests.cpp 3e36f2f7ab89b98de2c1a971e4ecca58c13ad642
> src/tests/containerizer/ns_tests.cpp cd668ebb3b9461bee00dc338c288e5df6eb8fe31
>
> Diff: https://reviews.apache.org/r/45495/diff/
>
>
> Testing
> -------
>
> sudo make check
>
> ../configure --with-network-isolator
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>