You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Marton Bod (Jira)" <ji...@apache.org> on 2020/04/03 08:00:26 UTC
[jira] [Updated] (HIVE-22750) Consolidate LockType naming

     [ https://issues.apache.org/jira/browse/HIVE-22750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marton Bod updated HIVE-22750:
------------------------------
    Description: 
Extend enum with string literal to remove unnecessary `id` to `char` casting for the LockType:
{code:java}
switch (lockType) {
            case EXCLUSIVE:
              lockChar = LOCK_EXCLUSIVE;
              break;
            case SHARED_READ:
              lockChar = LOCK_SHARED;
              break;
            case SHARED_WRITE:
              lockChar = LOCK_SEMI_SHARED;
              break;
          }
{code}
Consolidate LockType naming in code and schema upgrade scripts:
{code:java}
CASE WHEN HL.`HL_LOCK_TYPE` = 'e' THEN 'exclusive' WHEN HL.`HL_LOCK_TYPE` = 'r' THEN 'shared' WHEN HL.`HL_LOCK_TYPE` = 'w' THEN *'semi-shared'* END AS LOCK_TYPE,

{code}
EXCLUSIVE
 EXCL_WRITE
 SHARED_WRITE
 SHARED_READ

  was:


Extend enum with string literal to remove unnecessary `id` to `char` casting for the LockType:


{code:java}
switch (lockType) {
            case EXCLUSIVE:
              lockChar = LOCK_EXCLUSIVE;
              break;
            case SHARED_READ:
              lockChar = LOCK_SHARED;
              break;
            case SHARED_WRITE:
              lockChar = LOCK_SEMI_SHARED;
              break;
          }
{code}


Consolidate LockType naming in code and schema upgrade scripts:


{code:java}
CASE WHEN HL.`HL_LOCK_TYPE` = 'e' THEN 'exclusive' WHEN HL.`HL_LOCK_TYPE` = 'r' THEN 'shared' WHEN HL.`HL_LOCK_TYPE` = 'w' THEN *'semi-shared'* END AS LOCK_TYPE,

{code}

EXCL_DROP
EXCL_WRITE
SHARED_WRITE
SHARED_READ



> Consolidate LockType naming
> ---------------------------
>
>                 Key: HIVE-22750
>                 URL: https://issues.apache.org/jira/browse/HIVE-22750
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>            Reporter: Zoltan Chovan
>            Assignee: Marton Bod
>            Priority: Minor
>
> Extend enum with string literal to remove unnecessary `id` to `char` casting for the LockType:
> {code:java}
> switch (lockType) {
>             case EXCLUSIVE:
>               lockChar = LOCK_EXCLUSIVE;
>               break;
>             case SHARED_READ:
>               lockChar = LOCK_SHARED;
>               break;
>             case SHARED_WRITE:
>               lockChar = LOCK_SEMI_SHARED;
>               break;
>           }
> {code}
> Consolidate LockType naming in code and schema upgrade scripts:
> {code:java}
> CASE WHEN HL.`HL_LOCK_TYPE` = 'e' THEN 'exclusive' WHEN HL.`HL_LOCK_TYPE` = 'r' THEN 'shared' WHEN HL.`HL_LOCK_TYPE` = 'w' THEN *'semi-shared'* END AS LOCK_TYPE,
> {code}
> EXCLUSIVE
>  EXCL_WRITE
>  SHARED_WRITE
>  SHARED_READ



--
This message was sent by Atlassian Jira
(v8.3.4#803005)