[GitHub] [beam] jrmccluskey commented on a diff in pull request #25497: [#24789][prism] internal/jobservices metrics + tests

["jrmccluskey (via GitHub)" <gi...@apache.org>]

jrmccluskey commented on code in PR #25497:
URL: https://github.com/apache/beam/pull/25497#discussion_r1107763877


##########
sdks/go/pkg/beam/runners/prism/internal/jobservices/metrics.go:
##########
@@ -0,0 +1,497 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package jobservices
+
+import (
+	"bytes"
+	"fmt"
+	"hash/maphash"
+	"math"
+	"sort"
+	"sync"
+
+	"github.com/apache/beam/sdks/v2/go/pkg/beam/core/graph/coder"
+	"github.com/apache/beam/sdks/v2/go/pkg/beam/core/metrics"
+	fnpb "github.com/apache/beam/sdks/v2/go/pkg/beam/model/fnexecution_v1"
+	pipepb "github.com/apache/beam/sdks/v2/go/pkg/beam/model/pipeline_v1"
+	"golang.org/x/exp/constraints"
+	"golang.org/x/exp/slog"
+	"google.golang.org/protobuf/proto"
+	"google.golang.org/protobuf/reflect/protoreflect"
+)
+
+type labelsToKeyFunc func(string, map[string]string) metricKey
+
+type urnOps struct {
+	// keyFn produces the key for this metric from the labels.
+	// based on the required label set for the metric from it's spec.
+	keyFn labelsToKeyFunc
+	// newAccum produces an accumulator assuming we don't have an accumulator for it already.
+	// based on the type urn of the metric from it's spec.
+	newAccum accumFactory
+}
+
+var (
+	mUrn2Ops = map[string]urnOps{}
+)
+
+func init() {
+	mUrn2Spec := map[string]*pipepb.MonitoringInfoSpec{}
+	specs := (pipepb.MonitoringInfoSpecs_Enum)(0).Descriptor().Values()
+	for i := 0; i < specs.Len(); i++ {
+		enum := specs.ByNumber(protoreflect.EnumNumber(i))
+		spec := proto.GetExtension(enum.Options(), pipepb.E_MonitoringInfoSpec).(*pipepb.MonitoringInfoSpec)
+		mUrn2Spec[spec.GetUrn()] = spec
+	}
+	mUrn2Ops = buildUrnToOpsMap(mUrn2Spec)
+}
+
+// Should probably just construct a slice or map to get the urns out
+// since we'll ultimately be using them alot.

Review Comment:
   ```suggestion
   // since we'll ultimately be using them a lot.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org